feature/repo initialisation#1
Draft
PabloCorcho wants to merge 20 commits into
Draft
Conversation
paranoya
reviewed
Apr 14, 2025
| # List the flat fields | ||
| rss_set: | ||
| - "/home/pcorchoc/Develop/pykoala-tutorials/tutorials/data/koala/385R/27feb20009red.fits" | ||
| WaveOffsetCorrect : False |
Member
There was a problem hiding this comment.
Shouldn't it be called WavelengthCorrection, like the class?
paranoya
reviewed
Apr 14, 2025
| # Use a median filter to smooth the throughput across the dispersion axis | ||
| medfilt: 20 | ||
|
|
||
| AtmosphericExtinctionCorrection: |
Member
There was a problem hiding this comment.
In this case, I would rename AtmosphericExtCorrection to AtmosphericExtinctionCorrection
paranoya
reviewed
Apr 14, 2025
| AtmosphericExtinctionCorrection: | ||
| file: default | ||
|
|
||
| StandardStarsCal: |
paranoya
approved these changes
Apr 14, 2025
paranoya
left a comment
paranoya
left a comment
Member
There was a problem hiding this comment.
I find the structure very elegant and self-explanatory. I would only suggest following a more consistent naming convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR for creating the data reduction pipeline for KOALA.
For now I am only moving some stuff from pykoala and start thinking about a KOALA-centric architecture, so I won't merge anything yet.