Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
gviejo
requested changes
Apr 7, 2026
gviejo
requested changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
signalmodule, which contains functions for extracting envelopes and phases (using Hilbert transform).Most of the functions are wrappers around
scipy.signal.hilbert:apply_hilbert_transformcompute_hilbert_envelopecompute_hilbert_phaseAlso moved
detect_oscillatory_eventsto this module, since it is a better fit thanfiltering.In the future we will add a function to this module that uses something like
find_peaksand then interpolation to extract phases, see #584.Documentation
The new functions have detailed docstring examples.
A new user-guide was added for this module specifically, it focuses on extracting phases/envelopes.
Places that used the Hilbert transform that now use this module:
Testing
Tests have been added for:
scipy.Related issues
Addresess #568.