Skip to content

Update detect_oscillatory_events#588

Merged
gviejo merged 4 commits intodevfrom
587-detect-events
Apr 15, 2026
Merged

Update detect_oscillatory_events#588
gviejo merged 4 commits intodevfrom
587-detect-events

Conversation

@wulfdewolf
Copy link
Copy Markdown
Collaborator

@wulfdewolf wulfdewolf commented Apr 14, 2026

This short PR updates detect_oscillatory_events to use the hilbert transform vs. filt.filt before.

It further adds a snippet at the end of the new ripple detection tutorial where it is introduced and uses as a shorter version of everything that came before.

I've further added input type checks to the function and a test for them.

Addresses #587

@wulfdewolf wulfdewolf requested a review from gviejo as a code owner April 14, 2026 16:43
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pynapple/process/signal.py 95.65% 1 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
pynapple/process/signal.py 91.66% <95.65%> (+2.19%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gviejo gviejo merged commit c368058 into dev Apr 15, 2026
16 checks passed
@gviejo gviejo deleted the 587-detect-events branch April 15, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants