fix: use per-extension subdirectory in build_temp to prevent parallel build race (#5196)#5202
Open
fix: use per-extension subdirectory in build_temp to prevent parallel build race (#5196)#5202
Conversation
… build race
When building multiple extensions in parallel with -j, all extensions
shared the same build_temp directory. Object files with the same name
would overwrite each other, causing random build failures.
Fixed: derive a per-extension output_dir from ext.name.split('.').
e.g. pkg.ext1 -> build/temp.../pkg/ext1/
pkg.ext2 -> build/temp.../pkg/ext2/
Fixes pypa#5196
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5196
Root cause
All extensions share the same
build_tempdirectory when compiledin parallel with
-j. Thecompiler.compile()call usesoutput_dir=self.build_tempfor every extension, so.ofileswith the same name overwrite each other.
Fix
Derive a per-extension
output_dirfromext.name:pkg.ext1→build/temp.../pkg/ext1/pkg.ext2→build/temp.../pkg/ext2/Testing
Added unit test verifying the two extensions receive different
output_dirvalues.