Extend “Rename Selected Sheets” to support true batch renaming modes#3389
Draft
Copilot wants to merge 6 commits into
Draft
Extend “Rename Selected Sheets” to support true batch renaming modes#3389Copilot wants to merge 6 commits into
Copilot wants to merge 6 commits into
Conversation
Agent-Logs-Url: https://github.com/pyrevitlabs/pyRevit/sessions/f44fc21e-ca6b-4130-989e-c907d4b17d84 Co-authored-by: jmcouffin <7872003+jmcouffin@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jmcouffin
May 21, 2026 19:40
View session
Contributor
|
Unable to trigger custom agent "Code Reviewer". You have run out of credits 😔 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the pyRevitTools → Drawing Set → Sheets → “Rename Selected Sheets” command from simple case conversion into a true batch-renaming tool with multiple rename modes, preview/confirmation, and conflict/result reporting.
Changes:
- Added mode-driven batch rename operations: find/replace, prefix, suffix, uppercase, lowercase.
- Added precomputation of target names with preview + confirmation and categorized reporting (renamed/unchanged/conflicts/failed).
- Updated the
en_ustooltip text to reflect the expanded capabilities.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
extensions/pyRevitTools.extension/pyRevit.tab/Drawing Set.panel/Sheets.pulldown/Rename Selected Sheets.pushbutton/script.py |
Replaces the prior case-only renamer with mode-based batch renaming, preview, conflict checks, and 2-phase rename execution. |
extensions/pyRevitTools.extension/pyRevit.tab/Drawing Set.panel/Sheets.pulldown/Rename Selected Sheets.pushbutton/bundle.yaml |
Updates the English tooltip to describe the new batch rename features. |
Comment on lines
+254
to
+262
| unique_pairs = [] | ||
| for pair in valid_pairs: | ||
| name_taken = False | ||
| for sheet_id, sheet_name in all_sheet_names.items(): | ||
| if sheet_id in selected_sheet_ids: | ||
| continue | ||
| if sheet_name == pair['new_name']: | ||
| name_taken = True | ||
| break |
Contributor
Author
There was a problem hiding this comment.
Fixed in 7f286e7 — replaced the nested loop with a precomputed existing_names set built from all_sheet_names (excluding selected sheets), so the conflict check is now O(1) per candidate.
Comment on lines
+32
to
+34
| if find_txt == '': | ||
| forms.alert('Find text can not be empty.') | ||
| return None |
Contributor
Author
There was a problem hiding this comment.
Fixed in 2c45e3a — changed all three instances of "can not" to "cannot" (lines 33, 53, 66).
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pyrevitlabs/pyRevit/sessions/ff2babe9-505a-449a-b773-d1b0257326f4 Co-authored-by: jmcouffin <7872003+jmcouffin@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pyrevitlabs/pyRevit/sessions/970b7536-efaa-4399-b7fd-0ef0c280a244 Co-authored-by: jmcouffin <7872003+jmcouffin@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pyrevitlabs/pyRevit/sessions/a9656f4c-86f7-48af-8594-77e0691baf2c Co-authored-by: jmcouffin <7872003+jmcouffin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.