Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #319 +/- ##
===========================================
+ Coverage 80.49% 80.54% +0.04%
===========================================
Files 7 7
Lines 810 812 +2
===========================================
+ Hits 652 654 +2
Misses 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We originally added this local backup at the time because our systems were unstable and we lacked data. We did not want to lose a single fire image
Today, it is very rare for a system to be down, and we now have a large amount of data, so we can afford to lose an image from time to time
Moreover, we never actually retrieve this data from the Raspberry Pi. It is simply deleted by the garbage collector. This unnecessarily accelerates the wear of the SD card
let's keep the functionality if needed but turn it off by default