Open
Conversation
We used to pluck the following attributes from our "dataclass-ish" CPythonWorker and pass them as separate arguments: - parallel_tests (via lookup in `parallel`, a global dict) - timeout_factor (via `extra_factory_args`) - exclude_test_resources (via `extra_factory_args`) Just pass the whole CPythonWorker in. Also: Simplify if/else logic for adding the -j option, with a helper that can return an empty list. Also: Remove "-j2" from class-level testFlags: it always matched the default or was overridden.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to pluck the following attributes from CPythonWorker, our "dataclass-ish" config object, and pass them to builds:
parallel, a global dict)extra_factory_args)extra_factory_args)Instead, pass in the whole CPythonWorker.
Also: Simplify if/else logic for adding the -j option, with a helper that can return an empty list.
Also: Remove "-j2" from class-level testFlags: it always matched the default or was overridden.