-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-141860: Add on_error= keyword arg to multiprocessing.set_forkserver_preload
#141859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gpshead
wants to merge
21
commits into
python:main
Choose a base branch
from
gpshead:claude/forkserver-raise-exceptions-019rrqWeqQGL2zKWava8nshj
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+346
−30
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
8b7c3ee
Add raise_exceptions parameter to multiprocessing.set_forkserver_preload
gpshead e8836d5
Skip forkserver preload tests on platforms without fork support
gpshead 5ce91ba
Skip all forkserver tests on platforms without fork support
gpshead 75495cc
Refactor set_forkserver_preload to use on_error parameter
gpshead 84c9e5b
Fix unused import and make __notes__ test more robust
gpshead a399218
Fix warn mode to work when warnings are configured as errors
gpshead 9c3ba84
Change __main__ warning message from 'import' to 'preload'
gpshead 70c05d8
Refactor set_forkserver_preload to use _handle_preload helper
gpshead 045be92
Simplify temporary file handling in tests
gpshead 6d4c521
Remove obvious comments and improve import style in tests
gpshead 30c2cf8
Fix warn mode to work when warnings are configured as errors
gpshead bad9691
Add comments explaining exception catching strategy
gpshead 9d8125f
Use double quotes for string values in documentation
gpshead 2f8edb8
Fix warn mode to work when warnings are configured as errors
gpshead 622345d
Add Gregory P. Smith to NEWS entry contributors
gpshead 42e8eb1
Simplify comments and exception note message
gpshead 64ca5a0
Update _send_value docstring to explain pickling requirement
gpshead 5a8bfc6
Merge main into forkserver on_error branch
gpshead 128e7f0
Fix test hang by restoring __main__ state in TestHandlePreload
gpshead 54f9336
Add stderr capture and assertions to forkserver preload tests
gpshead 6ffe214
Refactor preload error handling into _handle_import_error helper
gpshead File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.