Skip to content

gh-143663: Perform path normalization in TarFile.extractall() #143665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
0xd6cb6d73 wants to merge 10 commits into
base: main
Choose a base branch
from
Open

gh-143663: Perform path normalization in TarFile.extractall() #143665

0xd6cb6d73 wants to merge 10 commits into from
+3 −1

Conversation

@0xd6cb6d73
Copy link

@0xd6cb6d73 0xd6cb6d73 commented Jan 10, 2026 •
edited by bedevere-app bot
Loading

This PR fixes an issue on Windows caused by non-normalized destination paths when calling extractall().

@python-cla-bot
Copy link

python-cla-bot bot commented Jan 10, 2026 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Jan 10, 2026
Open
@picnixz
Copy link
Member

picnixz commented Jan 10, 2026

Please do not open a PR until the bug has been acknowledged. We can't just normalize all paths. Normalization is not the default behavior. I will close thbe PR until it has been decided that this change should be done. Sorry.

@picnixz picnixz closed this Jan 10, 2026
@picnixz picnixz reopened this Jan 12, 2026
@0xd6cb6d73
Copy link
Author

0xd6cb6d73 commented Jan 13, 2026 •
edited
Loading

Ended up fixing the issue in extractall and not _get_extract_tarinfo as discussed in the issue because that ended up impacting the internal representation of tar objects in a way that broke a lot of tests. I think it's enough because the crash only shows up when calling lstat, which extract doesn't do, and _extract_member already perform the same separator conversion before writing to disk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0xd6cb6d73 @picnixz