Skip to content

gh-138050: Global cooling: use cold flag instead of warm flag in MAKE_WARM #143827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markshannon merged 1 commit into from
Jan 14, 2026
Merged

gh-138050: Global cooling: use cold flag instead of warm flag in MAKE_WARM #143827

markshannon merged 1 commit into from
Jan 14, 2026

Conversation

@cocolato
Copy link
Contributor

@cocolato cocolato commented Jan 14, 2026 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 14, 2026
Open
@markshannon markshannon changed the title gh-138050: Global cooling: use cold flag instead of wram flag in MAKE_WARM gh-138050: Global cooling: use cold flag instead of warm flag in MAKE_WARM Jan 14, 2026
@markshannon
Copy link
Member

markshannon commented Jan 14, 2026

On Aarch64, this changes the MAKE_WARM stencil from:

  mov     w8, #0x1
  strb    w8, [x20, #0x24]

to

  strb    wzr, [x20, #0x24]

markshannon
markshannon approved these changes Jan 14, 2026
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@markshannon markshannon merged commit 94dbce1 into python:main Jan 14, 2026
93 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cocolato @markshannon