Skip to content

gh-143825: Micro-optimizations to _make_key. #143844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhettinger merged 1 commit into from
Jan 14, 2026
+5 −3
Merged

gh-143825: Micro-optimizations to _make_key. #143844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Lib/functools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ def _unwrap_partialmethod(func):
### LRU Cache function decorator
################################################################################

_CacheInfo = namedtuple("CacheInfo", ["hits", "misses", "maxsize", "currsize"])
_CacheInfo = namedtuple("CacheInfo", ("hits", "misses", "maxsize", "currsize"))

def _make_key(args, kwds, typed,
kwd_mark = (object(),),
Expand All @@ -539,13 +539,15 @@ def _make_key(args, kwds, typed,
# distinct call from f(y=2, x=1) which will be cached separately.
key = args
if kwds:
key = list(key)
key += kwd_mark
for item in kwds.items():
key += item
key = tuple(key)
if typed:
key += tuple(type(v) for v in args)
key += tuple([type(v) for v in args])
if kwds:
key += tuple(type(v) for v in kwds.values())
key += tuple([type(v) for v in kwds.values()])
elif len(key) == 1 and type(key[0]) in fasttypes:
return key[0]
return key
Expand Down
Loading