Fix TLS hostname mismatch by honoring tls-server-name and defaulting to rustls#52
Merged
Merged
Conversation
Contributor
Author
|
@corka149 I had to touch the workflow to matrix different TLS implementation for different platform. Please feel free to push back if you've got concerns. Thanks! |
Contributor
Author
|
Thank you so much for the quick review @corka149 ! |
Contributor
|
Version 0.7.6 was released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tls-server-name(e.g., AKS private link).tls_server_name, causing hostname verification to fail.rustls.kube/ringso rustls works without a crypto-provider panic.tls-server-nameinto the resolved client config when missing.cargo build --releasepasses locally.