Fix tests that failed in Python 3.13 when building the conda-forge package#3923
Open
aywi wants to merge 3 commits intopytorch:mainfrom
Open
Fix tests that failed in Python 3.13 when building the conda-forge package#3923aywi wants to merge 3 commits intopytorch:mainfrom
aywi wants to merge 3 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3923
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Author
|
@NicolasHug @samanklesaria Please help take a look since there has been no response from the original code owners. Thanks! |
``` FAILED test/torchaudio_unittest/datasets/cmuarctic_test.py::TestCMUARCTIC::test_cmuarctic_path - ValueError: bad delimiter value FAILED test/torchaudio_unittest/datasets/cmuarctic_test.py::TestCMUARCTIC::test_cmuarctic_str - ValueError: bad delimiter value ```
`FutureWarning: functools.partial will be a method descriptor in future Python versions; wrap it in staticmethod() if you want to preserve the old behavior`
`TypeError: LRScheduler.__init__() got an unexpected keyword argument 'verbose'`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following tests failed in Python 3.13 when building the conda-forge package (conda-forge/torchaudio-feedstock#30):
This was caused by
FutureWarning: functools.partial will be a method descriptor in future Python versions; wrap it in staticmethod() if you want to preserve the old behaviorwith Python 3.13 (python/cpython#121027).These were caused by
csv.reader(text, delimiter="\n")intorchaudio/datasets/cmuarctic.py, which is not allowed with Python 3.13 (python/cpython#113796).Additionally, there were some
TypeError: LRScheduler.__init__() got an unexpected keyword argument 'verbose'in local tests, caused by the final deprecation of theverbosekwarg to theLRSchedulerconstructor with PyTorch 2.7 (pytorch/pytorch#147301) (has been deprecated since 2.2).