Support per-arch BuildKit replica counts and resize prod fleet#702
Merged
Conversation
**Impact:** OSDC `arc-cbr-production` BuildKit fleet. Other clusters unchanged
(per-arch keys are optional and fall back to the shared values).
**Risk:** low
Adds optional `buildkit.{amd64,arm64}_replicas` and `buildkit.{amd64,arm64}_pods_per_node`
overrides (generator + deploy.sh), defaulting to the existing `replicas_per_arch` /
`pods_per_node` when unset, so all other clusters render identically.
Prod fleet is resized to:
- amd64: m6id.24xlarge, 2/node, 42 vCPU/155 GiB — 32 replicas (was 12)
- arm64: m7gd.16xlarge, 4/node, ~14 vCPU/51 GiB — 8 replicas
arm64 moves to smaller pods (m7gd.16xlarge packed 4/node ≈ the pre-OSDC
m7g.4xlarge build runner: same Graviton3 family, ~16 vCPU/64 GiB) so we run more,
smaller arm64 builders. NodePool limits scale per-arch automatically.
Testing: `just test` pass (generate_buildkit.py 97%), `just lint` 13/13.
Signed-off-by: Huy Do <huydo@meta.com>
…ode) Signed-off-by: Huy Do <huydo@meta.com>
huydhn
commented
Jun 5, 2026
huydhn
commented
Jun 5, 2026
jeanschmidt
approved these changes
Jun 5, 2026
Contributor
|
Did you test your changes in arc-staging? I suspect you would need to change smoke tests as well, don't you? |
malfet
approved these changes
Jun 5, 2026
Contributor
Author
This was made on the flight, so yes, I need to test this on staging now, also the reason I haven't merged it yet :) |
Signed-off-by: Huy Do <huydo@meta.com>
huydhn
commented
Jun 6, 2026
Contributor
Author
|
(Claude here, posting on behalf of @huydhn.) Checked — deployed to Reverting the staging test config from this PR now so it only carries the per-arch mechanism + the prod change. |
Signed-off-by: Huy Do <huydo@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional per-arch
buildkit.{amd64,arm64}_replicasand..._pods_per_nodeoverrides (fall back to the sharedreplicas_per_arch/pods_per_node, so other clusters render unchanged), then resizes the prod fleet:m6id.24xlarge, 2/node, 42 vCPU/155 GiB — 32 replicas (was 12)m7gd.16xlarge, 4/node, ~14 vCPU/51 GiB — 8 replicas (smaller pods, more of them; ≈ the pre-OSDCm7g.4xlargebuild runner)NodePool limits scale per-arch automatically.
just testpass (97% cov),just lint13/13.Independent of the autoscaling work on #701.