[Executorch][llm] Add support for ring kv cache and ring attention#10608
Merged
facebook-github-bot merged 7 commits intoMay 13, 2025
Conversation
Introduced CachePositionManager to keep track of what is the position for each slot in ring kv cache. This is used to generate mask. Differential Revision: [D73891427](https://our.internmc.facebook.com/intern/diff/D73891427/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10608
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit c5cdb0c with merge base bf50527 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced May 1, 2025
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73891427 |
…ttention" Introduced CachePositionManager to keep track of what is the position for each slot in ring kv cache. This is used to generate mask. Differential Revision: [D73891427](https://our.internmc.facebook.com/intern/diff/D73891427/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73891427 |
kimishpatel
added
the
release notes: examples
digantdesai
approved these changes
May 5, 2025
larryliu0820
approved these changes
May 5, 2025
…ttention" Introduced CachePositionManager to keep track of what is the position for each slot in ring kv cache. This is used to generate mask. Differential Revision: [D73891427](https://our.internmc.facebook.com/intern/diff/D73891427/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73891427 |
…ttention" Introduced CachePositionManager to keep track of what is the position for each slot in ring kv cache. This is used to generate mask. Differential Revision: [D73891427](https://our.internmc.facebook.com/intern/diff/D73891427/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73891427 |
…ttention" Introduced CachePositionManager to keep track of what is the position for each slot in ring kv cache. This is used to generate mask. Differential Revision: [D73891427](https://our.internmc.facebook.com/intern/diff/D73891427/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73891427 |
…ttention" Introduced CachePositionManager to keep track of what is the position for each slot in ring kv cache. This is used to generate mask. Differential Revision: [D73891427](https://our.internmc.facebook.com/intern/diff/D73891427/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73891427 |
…ttention" Introduced CachePositionManager to keep track of what is the position for each slot in ring kv cache. This is used to generate mask. Differential Revision: [D73891427](https://our.internmc.facebook.com/intern/diff/D73891427/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73891427 |
facebook-github-bot
merged commit 3539275
into
gh/kimishpatel/185/base
91 of 94 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
May 13, 2025
…10832) Pull Request resolved: #10608 Introduced CachePositionManager to keep track of what is the position for each slot in ring kv cache. This is used to generate mask. ghstack-source-id: 283404678 @exported-using-ghexport Differential Revision: [D73891427](https://our.internmc.facebook.com/intern/diff/D73891427/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Introduced CachePositionManager to keep track of what is the position for each slot in ring kv cache. This is used to generate mask.
Differential Revision: D73891427