[ET-VK] Reducing memory wastage by tightening DescriptorPoolConfig values.#10784
[ET-VK] Reducing memory wastage by tightening DescriptorPoolConfig values.#10784trviv wants to merge 1 commit into
Conversation
…lues. This change replaces std::max(*descriptor_type_count*, max_sets) with *descriptor_type_count*, when creating DescriptorPoolConfig in ComputeGraph since Vulkan does not need to have at least one of each *descriptor_type_count* per set. Differential Revision: [D74452971](https://our.internmc.facebook.com/intern/diff/D74452971/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10784
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New FailuresAs of commit 39e8488 with merge base 277c39d ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…lues. This change replaces std::max(*descriptor_type_count*, max_sets) with *descriptor_type_count*, when creating DescriptorPoolConfig in ComputeGraph since Vulkan does not need to have at least one of each *descriptor_type_count* per set. Differential Revision: [D74452971](https://our.internmc.facebook.com/intern/diff/D74452971/) ghstack-source-id: 283034895 Pull Request resolved: #10784
|
This pull request was exported from Phabricator. Differential Revision: D74452971 |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
2 similar comments
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Stack from ghstack (oldest at bottom):
This change replaces std::max(descriptor_type_count, max_sets) with descriptor_type_count, when creating DescriptorPoolConfig in ComputeGraph since Vulkan does not need to have at least one of each descriptor_type_count per set.
Differential Revision: D74452971