Skip to content

[ET-VK] Reducing memory wastage by tightening DescriptorPoolConfig values.#10784

Closed
trviv wants to merge 1 commit into
gh/trivedivivek/84/basefrom
gh/trivedivivek/84/head
Closed

[ET-VK] Reducing memory wastage by tightening DescriptorPoolConfig values.#10784
trviv wants to merge 1 commit into
gh/trivedivivek/84/basefrom
gh/trivedivivek/84/head

Conversation

@trviv

@trviv trviv commented May 9, 2025

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

This change replaces std::max(descriptor_type_count, max_sets) with descriptor_type_count, when creating DescriptorPoolConfig in ComputeGraph since Vulkan does not need to have at least one of each descriptor_type_count per set.

Differential Revision: D74452971

…lues.

This change replaces std::max(*descriptor_type_count*, max_sets) with *descriptor_type_count*, when creating DescriptorPoolConfig in ComputeGraph since Vulkan does not need to have at least one of each *descriptor_type_count* per set.

Differential Revision: [D74452971](https://our.internmc.facebook.com/intern/diff/D74452971/)

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented May 9, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10784

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit 39e8488 with merge base 277c39d (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 9, 2025
trviv added a commit that referenced this pull request May 9, 2025
…lues.

This change replaces std::max(*descriptor_type_count*, max_sets) with *descriptor_type_count*, when creating DescriptorPoolConfig in ComputeGraph since Vulkan does not need to have at least one of each *descriptor_type_count* per set.

Differential Revision: [D74452971](https://our.internmc.facebook.com/intern/diff/D74452971/)

ghstack-source-id: 283034895
Pull Request resolved: #10784
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74452971

@github-actions

github-actions Bot commented Sep 1, 2025

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions Bot added the Stale PRs inactive for over 60 days label Sep 1, 2025
@github-actions

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

2 similar comments
@github-actions

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions

github-actions Bot commented Mar 1, 2026

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions Bot closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Stale PRs inactive for over 60 days topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants