Skip to content

[Executorch][llm] Make custom update cache op operate on indices#10834

Merged
kimishpatel merged 1 commit into
mainfrom
gh/kimishpatel/187/orig
May 13, 2025
Merged

[Executorch][llm] Make custom update cache op operate on indices#10834
kimishpatel merged 1 commit into
mainfrom
gh/kimishpatel/187/orig

Conversation

@pytorchbot

@pytorchbot pytorchbot commented May 13, 2025

Copy link
Copy Markdown
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #10610 by @kimishpatel
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/187/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/187/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/186/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/187/orig
@diff-train-skip-merge

@pytorch-bot

pytorch-bot Bot commented May 13, 2025 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10834

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 3 Pending

As of commit b994a1a with merge base 0bb059f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 13, 2025
@kimishpatel kimishpatel force-pushed the gh/kimishpatel/186/orig branch from 0cab6ab to aaf996b Compare May 13, 2025 14:27
Base automatically changed from gh/kimishpatel/186/orig to main May 13, 2025 14:29
@kimishpatel
[Executorch][llm] Make custom update cache op operate on indices
b994a1a 
Pull Request resolved: #10610

This allows us to use ring buffer kv cache
ghstack-source-id: 283404676
@exported-using-ghexport

Differential Revision: [D73891424](https://our.internmc.facebook.com/intern/diff/D73891424/)
@kimishpatel kimishpatel force-pushed the gh/kimishpatel/187/orig branch from bfcaf89 to b994a1a Compare May 13, 2025 14:31
@github-actions

github-actions Bot commented May 13, 2025

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:.

If not, please add the release notes: none label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kimishpatel kimishpatel merged commit 0b231c4 into main May 13, 2025
91 of 92 checks passed
@kimishpatel kimishpatel deleted the gh/kimishpatel/187/orig branch May 13, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimishpatel kimishpatel kimishpatel approved these changes

@jackzhxng jackzhxng Awaiting requested review from jackzhxng

@iseeyuan iseeyuan Awaiting requested review from iseeyuan

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@swolchok swolchok Awaiting requested review from swolchok

@lucylq lucylq Awaiting requested review from lucylq

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pytorchbot @kimishpatel @facebook-github-bot