[Executorch][llm] Enable local global attention in export_llama script#10836
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10836
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 12 New Failures, 1 Unrelated FailureAs of commit 7ee018b with merge base ef30b25 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kimishpatel
force-pushed
the
gh/kimishpatel/188/orig
branch
from
ed32169 to
084bfe2
Compare
kimishpatel
requested review from
iseeyuan,
larryliu0820 and
swolchok
as code owners
Pull Request resolved: #10612 Added a new option of --local_global_attention that takes in pattern of sizes to determine which layers are using local sliding window attention. For example, [0, 256, 256, 0, 256, 256] can be used for 6 layers transformer. Or you can also use [0, 256, 256] as pattern you want to repeat. ghstack-source-id: 283404674 @exported-using-ghexport Differential Revision: [D73891423](https://our.internmc.facebook.com/intern/diff/D73891423/)
kimishpatel
force-pushed
the
gh/kimishpatel/189/orig
branch
from
7fddb24 to
7ee018b
Compare
This PR needs a
|
kimishpatel
approved these changes
May 13, 2025
Contributor
|
merging this while the ci is broken. @jackzhxng has diff in progress to fix this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #10612 by @kimishpatel
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/189/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/189/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/188/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/189/orig
@diff-train-skip-merge