Mostly sync BlasKernel.cpp with ATen ReducedPrecisionGemvFastPathKernel#10868
Merged
Conversation
The two files were similar, but diverged due to recent changes. Since we have sharing of PyTorch headers, we can keep them mostly the same; differences are some of the namespace stuff and a couple of EXECUTORCH NOTEs. Differential Revision: [D74702689](https://our.internmc.facebook.com/intern/diff/D74702689/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
May 14, 2025
The two files were similar, but diverged due to recent changes. Since we have sharing of PyTorch headers, we can keep them mostly the same; differences are some of the namespace stuff and a couple of EXECUTORCH NOTEs. Differential Revision: [D74702689](https://our.internmc.facebook.com/intern/diff/D74702689/) ghstack-source-id: 283857974 Pull Request resolved: #10868
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10868
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 27af7f6 with merge base 9ded0a2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74702689 |
kimishpatel
approved these changes
May 14, 2025
kimishpatel
left a comment
kimishpatel
left a comment
Contributor
There was a problem hiding this comment.
bunch of ci failures. not sure if they are related. can we ask the person who filed the rpi issue to see if this fixes it?
Contributor
Author
|
/pytorch/executorch/kernels/optimized/blas/BlasKernel.cpp:17:10: fatal error: 'ATen/cpu/vec/functional.h' file not found |
…astPathKernel" The two files were similar, but diverged due to recent changes. Since we have sharing of PyTorch headers, we can keep them mostly the same; differences are some of the namespace stuff and a couple of EXECUTORCH NOTEs. Differential Revision: [D74702689](https://our.internmc.facebook.com/intern/diff/D74702689/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
May 14, 2025
Pull Request resolved: #10868 The two files were similar, but diverged due to recent changes. Since we have sharing of PyTorch headers, we can keep them mostly the same; differences are some of the namespace stuff and a couple of EXECUTORCH NOTEs. ghstack-source-id: 284071626 @exported-using-ghexport Differential Revision: [D74702689](https://our.internmc.facebook.com/intern/diff/D74702689/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74702689 |
…mvFastPathKernel" The two files were similar, but diverged due to recent changes. Since we have sharing of PyTorch headers, we can keep them mostly the same; differences are some of the namespace stuff and a couple of EXECUTORCH NOTEs. Differential Revision: [D74702689](https://our.internmc.facebook.com/intern/diff/D74702689/) [ghstack-poisoned]
swolchok
requested review from
jathu,
kirklandsign and
larryliu0820
as code owners
swolchok
added a commit
that referenced
this pull request
May 14, 2025
Pull Request resolved: #10868 The two files were similar, but diverged due to recent changes. Since we have sharing of PyTorch headers, we can keep them mostly the same; differences are some of the namespace stuff and a couple of EXECUTORCH NOTEs. ghstack-source-id: 284080528 @exported-using-ghexport Differential Revision: [D74702689](https://our.internmc.facebook.com/intern/diff/D74702689/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74702689 |
swolchok
added
the
release notes: ops & kernels
…emvFastPathKernel" The two files were similar, but diverged due to recent changes. Since we have sharing of PyTorch headers, we can keep them mostly the same; differences are some of the namespace stuff and a couple of EXECUTORCH NOTEs. Differential Revision: [D74702689](https://our.internmc.facebook.com/intern/diff/D74702689/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
May 15, 2025
Pull Request resolved: #10868 The two files were similar, but diverged due to recent changes. Since we have sharing of PyTorch headers, we can keep them mostly the same; differences are some of the namespace stuff and a couple of EXECUTORCH NOTEs. ghstack-source-id: 284241247 @exported-using-ghexport Differential Revision: [D74702689](https://our.internmc.facebook.com/intern/diff/D74702689/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74702689 |
…ReducedPrecisionGemvFastPathKernel" The two files were similar, but diverged due to recent changes. Since we have sharing of PyTorch headers, we can keep them mostly the same; differences are some of the namespace stuff, lintrunner, and a couple of EXECUTORCH NOTEs. Differential Revision: [D74702689](https://our.internmc.facebook.com/intern/diff/D74702689/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
May 15, 2025
Pull Request resolved: #10868 The two files were similar, but diverged due to recent changes. Since we have sharing of PyTorch headers, we can keep them mostly the same; differences are some of the namespace stuff, lintrunner, and a couple of EXECUTORCH NOTEs. ghstack-source-id: 284287912 @exported-using-ghexport Differential Revision: [D74702689](https://our.internmc.facebook.com/intern/diff/D74702689/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D74702689/)!
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74702689 |
facebook-github-bot
merged commit 74605de
into
gh/swolchok/436/base
85 of 88 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
May 16, 2025
…el (#10941) Pull Request resolved: #10868 The two files were similar, but diverged due to recent changes. Since we have sharing of PyTorch headers, we can keep them mostly the same; differences are some of the namespace stuff, lintrunner, and a couple of EXECUTORCH NOTEs. ghstack-source-id: 284287912 @exported-using-ghexport Differential Revision: [D74702689](https://our.internmc.facebook.com/intern/diff/D74702689/)
hinriksnaer
pushed a commit
to hinriksnaer/executorch
that referenced
this pull request
May 19, 2025
…el (pytorch#10941) Pull Request resolved: pytorch#10868 The two files were similar, but diverged due to recent changes. Since we have sharing of PyTorch headers, we can keep them mostly the same; differences are some of the namespace stuff, lintrunner, and a couple of EXECUTORCH NOTEs. ghstack-source-id: 284287912 @exported-using-ghexport Differential Revision: [D74702689](https://our.internmc.facebook.com/intern/diff/D74702689/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The two files were similar, but diverged due to recent changes. Since we have sharing of PyTorch headers, we can keep them mostly the same; differences are some of the namespace stuff, lintrunner, and a couple of EXECUTORCH NOTEs.
Differential Revision: D74702689