[ET-VK][Ops] aten.tan.default from scratch implementation#11046
Merged
Conversation
Following the instructions here for creating a new operator from scratch for learning purposes: https://www.internalfb.com/wiki/ExecuTorch_Vulkan_Backend/Development_0/Adding_a_New_Operator_Implementation/ Goal is to create a tan operator and its test case Differential Revision: [D75100188](https://our.internmc.facebook.com/intern/diff/D75100188/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11046
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit e6521f7 with merge base 3ad9419 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75100188 |
Following the instructions here for creating a new operator from scratch for learning purposes: https://www.internalfb.com/wiki/ExecuTorch_Vulkan_Backend/Development_0/Adding_a_New_Operator_Implementation/ Goal is to create a tan operator and its test case Differential Revision: [D75100188](https://our.internmc.facebook.com/intern/diff/D75100188/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75100188 |
Following the instructions here for creating a new operator from scratch for learning purposes: https://www.internalfb.com/wiki/ExecuTorch_Vulkan_Backend/Development_0/Adding_a_New_Operator_Implementation/ Goal is to create a tan operator and its test case Differential Revision: [D75100188](https://our.internmc.facebook.com/intern/diff/D75100188/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75100188 |
Following the instructions here for creating a new operator from scratch for learning purposes: https://www.internalfb.com/wiki/ExecuTorch_Vulkan_Backend/Development_0/Adding_a_New_Operator_Implementation/ Goal is to create a tan operator and its test case Differential Revision: [D75100188](https://our.internmc.facebook.com/intern/diff/D75100188/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75100188 |
trviv
approved these changes
May 22, 2025
Following the instructions here for creating a new operator from scratch for learning purposes: https://www.internalfb.com/wiki/ExecuTorch_Vulkan_Backend/Development_0/Adding_a_New_Operator_Implementation/ Goal is to create a tan operator and its test case Differential Revision: [D75100188](https://our.internmc.facebook.com/intern/diff/D75100188/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75100188 |
Following the instructions here for creating a new operator from scratch for learning purposes: https://www.internalfb.com/wiki/ExecuTorch_Vulkan_Backend/Development_0/Adding_a_New_Operator_Implementation/ Goal is to create a tan operator and its test case Differential Revision: [D75100188](https://our.internmc.facebook.com/intern/diff/D75100188/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75100188 |
Following the instructions here for creating a new operator from scratch for learning purposes: https://www.internalfb.com/wiki/ExecuTorch_Vulkan_Backend/Development_0/Adding_a_New_Operator_Implementation/ Goal is to create a tan operator and its test case Differential Revision: [D75100188](https://our.internmc.facebook.com/intern/diff/D75100188/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75100188 |
Following the instructions here for creating a new operator from scratch for learning purposes: https://www.internalfb.com/wiki/ExecuTorch_Vulkan_Backend/Development_0/Adding_a_New_Operator_Implementation/ Goal is to create a tan operator and its test case Differential Revision: [D75100188](https://our.internmc.facebook.com/intern/diff/D75100188/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75100188 |
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
lucylq
pushed a commit
that referenced
this pull request
Jun 4, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11046 by @ahmtox ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/ahmtox/2/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/ahmtox/2/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/ahmtox/2/orig @diff-train-skip-merge Co-authored-by: morelos <morelos@devvm4573.ash0.facebook.com>
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#11046 Goal is to create the tan operator and its test case ghstack-source-id: 286384697 @exported-using-ghexport Differential Revision: [D75100188](https://our.internmc.facebook.com/intern/diff/D75100188/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Following the instructions here for creating a new operator from scratch for learning purposes:
https://www.internalfb.com/wiki/ExecuTorch_Vulkan_Backend/Development_0/Adding_a_New_Operator_Implementation/
Goal is to create a tan operator and its test case
Differential Revision: D75100188