[ET-VK] Tuning local workgroup size calculation for conv2d pw to improve performance.#11135
Merged
facebook-github-bot merged 6 commits intoMay 28, 2025
Merged
Conversation
…ove performance.
This diff adjusts the local workgroup size (`local_wg_size`) based on batch count (stored in `wg_size[1]`), to improve conv2d pw performance.
* If `wg_size[1]` is a multiple of 8, `local_wg_size_y` is set to 8.
* If `wg_size[1]` is a multiple of 4, `local_wg_size_y` is set to 4.
* If `wg_size[1]` is a multiple of 2, `local_wg_size_y` is set to 2.
* Otherwise, we default to `local_wg_size_y` = 1.
The dispatch size in 2 dimensions is then calculate based on `{64 / local_wg_size_y, local_wg_size_y, 1}`.
Differential Revision: [D75420517](https://our.internmc.facebook.com/intern/diff/D75420517/)
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11135
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit ea2e9d5 with merge base 380eb5f ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced May 24, 2025
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75420517 |
… pw to improve performance."
This diff adjusts the local workgroup size (`local_wg_size`) based on batch count (stored in `wg_size[1]`), to improve conv2d pw performance.
* If `wg_size[1]` is a multiple of 8, `local_wg_size_y` is set to 8.
* If `wg_size[1]` is a multiple of 4, `local_wg_size_y` is set to 4.
* If `wg_size[1]` is a multiple of 2, `local_wg_size_y` is set to 2.
* Otherwise, we default to `local_wg_size_y` = 1.
The dispatch size in 2 dimensions is then calculate based on `{64 / local_wg_size_y, local_wg_size_y, 1}`.
Differential Revision: [D75420517](https://our.internmc.facebook.com/intern/diff/D75420517/)
[ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75420517 |
SS-JIA
approved these changes
May 27, 2025
… pw to improve performance."
This diff adjusts the local workgroup size (`local_wg_size`) based on batch count (stored in `wg_size[1]`), to improve conv2d pw performance.
* If `wg_size[1]` is a multiple of 8, `local_wg_size_y` is set to 8.
* If `wg_size[1]` is a multiple of 4, `local_wg_size_y` is set to 4.
* If `wg_size[1]` is a multiple of 2, `local_wg_size_y` is set to 2.
* Otherwise, we default to `local_wg_size_y` = 1.
The dispatch size in 2 dimensions is then calculate based on `{64 / local_wg_size_y, local_wg_size_y, 1}`.
Differential Revision: [D75420517](https://our.internmc.facebook.com/intern/diff/D75420517/)
[ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75420517 |
… pw to improve performance."
This diff adjusts the local workgroup size (`local_wg_size`) based on batch count (stored in `wg_size[1]`), to improve conv2d pw performance.
* If `wg_size[1]` is a multiple of 8, `local_wg_size_y` is set to 8.
* If `wg_size[1]` is a multiple of 4, `local_wg_size_y` is set to 4.
* If `wg_size[1]` is a multiple of 2, `local_wg_size_y` is set to 2.
* Otherwise, we default to `local_wg_size_y` = 1.
The dispatch size in 2 dimensions is then calculate based on `{64 / local_wg_size_y, local_wg_size_y, 1}`.
Differential Revision: [D75420517](https://our.internmc.facebook.com/intern/diff/D75420517/)
[ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75420517 |
… pw to improve performance."
This diff adjusts the local workgroup size (`local_wg_size`) based on batch count (stored in `wg_size[1]`), to improve conv2d pw performance.
* If `wg_size[1]` is a multiple of 8, `local_wg_size_y` is set to 8.
* If `wg_size[1]` is a multiple of 4, `local_wg_size_y` is set to 4.
* If `wg_size[1]` is a multiple of 2, `local_wg_size_y` is set to 2.
* Otherwise, we default to `local_wg_size_y` = 1.
The dispatch size in 2 dimensions is then calculate based on `{64 / local_wg_size_y, local_wg_size_y, 1}`.
Differential Revision: [D75420517](https://our.internmc.facebook.com/intern/diff/D75420517/)
[ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75420517 |
… pw to improve performance."
This diff adjusts the local workgroup size (`local_wg_size`) based on batch count (stored in `wg_size[1]`), to improve conv2d pw performance.
* If `wg_size[1]` is a multiple of 8, `local_wg_size_y` is set to 8.
* If `wg_size[1]` is a multiple of 4, `local_wg_size_y` is set to 4.
* If `wg_size[1]` is a multiple of 2, `local_wg_size_y` is set to 2.
* Otherwise, we default to `local_wg_size_y` = 1.
The dispatch size in 2 dimensions is then calculate based on `{64 / local_wg_size_y, local_wg_size_y, 1}`.
Differential Revision: [D75420517](https://our.internmc.facebook.com/intern/diff/D75420517/)
[ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75420517 |
facebook-github-bot
merged commit f8572ef
into
gh/trivedivivek/95/base
96 of 98 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
trviv
added a commit
that referenced
this pull request
May 29, 2025
…ove performance. (#11188) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11135 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/95/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/95/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/94/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/95/orig @diff-train-skip-merge --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff adjusts the local workgroup size (
local_wg_size) based on batch count (stored inwg_size[1]), to improve conv2d pw performance.wg_size[1]is a multiple of 8,local_wg_size_yis set to 8.wg_size[1]is a multiple of 4,local_wg_size_yis set to 4.wg_size[1]is a multiple of 2,local_wg_size_yis set to 2.local_wg_size_y= 1.The dispatch size in 2 dimensions is then calculate based on
{64 / local_wg_size_y, local_wg_size_y, 1}.Differential Revision: D75420517