Skip to content

Phi3 runner uses TextLLMRunner#11551

Closed
larryliu0820 wants to merge 1 commit into
mainfrom
phi3_runner
Closed

Phi3 runner uses TextLLMRunner#11551
larryliu0820 wants to merge 1 commit into
mainfrom
phi3_runner

Conversation

@larryliu0820

@larryliu0820 larryliu0820 commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

As titled.

@pytorch-bot

pytorch-bot Bot commented Jun 11, 2025 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11551

Note: Links to docs will display an error until the docs builds have been completed.

❌ 27 New Failures

As of commit 7418d2e with merge base 042eb1a (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 11, 2025
@github-actions

github-actions Bot commented Jun 11, 2025

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@larryliu0820 larryliu0820 requested a review from shoumikhin as a code owner June 13, 2025 07:27
mergennachin
mergennachin reviewed Jun 13, 2025
View reviewed changes
Comment thread extension/tensor/tensor_ptr_maker.h Outdated
Comment thread extension/llm/runner/text_prefiller.h Outdated
Comment thread extension/llm/runner/text_llm_runner.cpp Outdated
Comment thread examples/models/phi-3-mini/main.cpp
Comment thread examples/models/phi-3-mini/CMakeLists.txt Outdated
shoumikhin
shoumikhin reviewed Jun 13, 2025
View reviewed changes
Comment thread extension/tensor/tensor_ptr_maker.cpp Outdated
shoumikhin
shoumikhin reviewed Jun 13, 2025
View reviewed changes
Comment thread examples/models/phi-3-mini/main.cpp
@mergennachin

mergennachin commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

@larryliu0820 do you plan to have this as part of 0.7?

@larryliu0820

larryliu0820 commented Jul 11, 2025

Copy link
Copy Markdown
Contributor Author

ok rebasing

@larryliu0820
Phi3 runner uses TextLLMRunner
7418d2e 
As titled, this PR started to use `TextLLMRunner` to run phi-3-mini.

Eager model comes from Huggingface, not using kv cache as custom op
because it is only being supported on Optimum-executorch repo.

Performance may not be the best.
@larryliu0820

larryliu0820 commented Jul 15, 2025

Copy link
Copy Markdown
Contributor Author

Merged in #12482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shoumikhin shoumikhin shoumikhin approved these changes

@mergennachin mergennachin mergennachin left review comments

@jathu jathu Awaiting requested review from jathu

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

@iseeyuan iseeyuan Awaiting requested review from iseeyuan

@swolchok swolchok Awaiting requested review from swolchok

@lucylq lucylq Awaiting requested review from lucylq

+1 more reviewer

@jackzhxng jackzhxng jackzhxng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@larryliu0820 @mergennachin @shoumikhin @jackzhxng @facebook-github-bot