[XNNPACK Quantizer] Select between TConvs and Convs#11732
Merged
Conversation
Allow selection of Difference between transposed convs and regular convs. Previously, we grouped all conv targets together (transposed and regular convs), but now we enable better per-operator selection Differential Revision: [D76641838](https://our.internmc.facebook.com/intern/diff/D76641838/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11732
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 0aa7950 with merge base 057558f ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mcr229
added a commit
that referenced
this pull request
Jun 16, 2025
Allow selection of Difference between transposed convs and regular convs. Previously, we grouped all conv targets together (transposed and regular convs), but now we enable better per-operator selection Differential Revision: [D76641838](https://our.internmc.facebook.com/intern/diff/D76641838/) ghstack-source-id: 290405131 Pull Request resolved: #11732
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76641838 |
This PR needs a
|
GregoryComer
approved these changes
Jun 16, 2025
Allow selection of Difference between transposed convs and regular convs. Previously, we grouped all conv targets together (transposed and regular convs), but now we enable better per-operator selection Differential Revision: [D76641838](https://our.internmc.facebook.com/intern/diff/D76641838/) [ghstack-poisoned]
mcr229
added a commit
that referenced
this pull request
Jun 17, 2025
Pull Request resolved: #11732 Allow selection of Difference between transposed convs and regular convs. Previously, we grouped all conv targets together (transposed and regular convs), but now we enable better per-operator selection ghstack-source-id: 291033631 Differential Revision: [D76641838](https://our.internmc.facebook.com/intern/diff/D76641838/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76641838 |
facebook-github-bot
merged commit 00c08c6
into
gh/mcr229/33/base
95 of 98 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
GregoryComer
pushed a commit
that referenced
this pull request
Jun 23, 2025
Pull Request resolved: #11732 Allow selection of Difference between transposed convs and regular convs. Previously, we grouped all conv targets together (transposed and regular convs), but now we enable better per-operator selection ghstack-source-id: 291033631 Differential Revision: [D76641838](https://our.internmc.facebook.com/intern/diff/D76641838/)
GregoryComer
pushed a commit
that referenced
this pull request
Jun 24, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11732 by @mcr229 ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/mcr229/33/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/mcr229/33/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/mcr229/32/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/mcr229/33/orig @diff-train-skip-merge --------- Co-authored-by: Max Ren <maxren@meta.com>
hinriksnaer
pushed a commit
to hinriksnaer/executorch
that referenced
this pull request
Jun 26, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#11732 by @mcr229 ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/mcr229/33/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/mcr229/33/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/mcr229/32/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/mcr229/33/orig @diff-train-skip-merge --------- Co-authored-by: Max Ren <maxren@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Allow selection of Difference between transposed convs and regular convs. Previously, we grouped all conv targets together (transposed and regular convs), but now we enable better per-operator selection
Differential Revision: D76641838