Skip to content

[ET-VK][Ops] enabling double support for quantization and dequantization ops#11795

Merged
ahmtox merged 2 commits into
mainfrom
gh/ahmtox/18/orig
Jun 18, 2025
Merged

[ET-VK][Ops] enabling double support for quantization and dequantization ops#11795
ahmtox merged 2 commits into
mainfrom
gh/ahmtox/18/orig

Conversation

@pytorchbot

@pytorchbot pytorchbot commented Jun 18, 2025

Copy link
Copy Markdown
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #11553 by @ahmtox
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/ahmtox/18/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/ahmtox/18/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/ahmtox/18/orig
@diff-train-skip-merge

[ET-VK][Ops] enabling double support for quantization and dequantizat…
0c8fb18 
…ion ops

Pull Request resolved: #11553

# Context
Since we enabled the possibility for double support in an earlier diff, this enables double support for quantization and dequantization. Since there are limitations to how 64bit can be supported, the expectation is that IO is to be downgraded to 32bit.

# Changes
We create additional test cases for double support and make sure to pass in the double if its permitted (it's only allowed in buffers), and we also make sure to include double variants in the corresponding YAML files for quantization and dequantization.
ghstack-source-id: 291249593
@exported-using-ghexport

Differential Revision: [D76289197](https://our.internmc.facebook.com/intern/diff/D76289197/)
@pytorchbot pytorchbot requested a review from SS-JIA as a code owner June 18, 2025 18:44
@pytorch-bot

pytorch-bot Bot commented Jun 18, 2025 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11795

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 12 Pending, 1 Unrelated Failure

As of commit d5ab17f with merge base ee7e29f (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 18, 2025
@github-actions

github-actions Bot commented Jun 18, 2025

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@ahmtox ahmtox merged commit 5006a14 into main Jun 18, 2025
95 of 96 checks passed
@ahmtox ahmtox deleted the gh/ahmtox/18/orig branch June 18, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SS-JIA SS-JIA Awaiting requested review from SS-JIA SS-JIA is a code owner

1 more reviewer

@cccclai cccclai cccclai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pytorchbot @cccclai @facebook-github-bot @ahmtox