Install libcpp from release package other than apt-get by cccclai · Pull Request #11832 · pytorch/executorch

cccclai · 2025-06-20T21:16:05Z

Stack from ghstack (oldest at bottom):

-> Install libcpp from release package other than apt-get #11832

A few changes

Use the release package from https://releases.llvm.org/ to install libcpp, so we can install from different linux in addition to Ubuntu
Seperate out the qnn version and the url to a seperate file, for better versin management in the future

Differential Revision: D77048745

Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745/) [ghstack-poisoned]

pytorch-bot · 2025-06-20T21:16:08Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11832

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

linux.aws.h100.8 instance is down, potentially longer queue on linux.aws.h100

❌ 1 New Failure

As of commit e88d5f1 with merge base 413dee4 ():

NEW FAILURE - The following job has failed:

pull / test-eval_llama-mmlu-linux / linux-job (gh)
RuntimeError: Command docker exec -t 93e6096ef0ef0262da548b9c1f8ae677073f438e2af5228695a839429f511984 /exec failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745/) ghstack-source-id: 291737317 Pull Request resolved: #11832

facebook-github-bot · 2025-06-20T21:16:13Z

This pull request was exported from Phabricator. Differential Revision: D77048745

github-actions · 2025-06-20T21:16:42Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

A few changes 1. Use the release package from https://releases.llvm.org/ to install libcpp, so we can install from different linux in addition to Ubuntu 2. Seperate out the qnn version and the url to a seperate file, for better versin management in the future Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745/) Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745) [ghstack-poisoned]

Pull Request resolved: #11832 A few changes 1. Use the release package from https://releases.llvm.org/ to install libcpp, so we can install from different linux in addition to Ubuntu 2. Seperate out the qnn version and the url to a seperate file, for better versin management in the future Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745/) ghstack-source-id: 291962443

facebook-github-bot · 2025-06-22T21:20:48Z

This pull request was exported from Phabricator. Differential Revision: D77048745

A few changes 1. Use the release package from https://releases.llvm.org/ to install libcpp, so we can install from different linux in addition to Ubuntu 2. Seperate out the qnn version and the url to a seperate file, for better versin management in the future Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745/) Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745) [ghstack-poisoned]

Pull Request resolved: #11832 A few changes 1. Use the release package from https://releases.llvm.org/ to install libcpp, so we can install from different linux in addition to Ubuntu 2. Seperate out the qnn version and the url to a seperate file, for better versin management in the future ghstack-source-id: 291963669 Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745/)

facebook-github-bot · 2025-06-22T21:29:09Z

This pull request was exported from Phabricator. Differential Revision: D77048745

A few changes 1. Use the release package from https://releases.llvm.org/ to install libcpp, so we can install from different linux in addition to Ubuntu 2. Seperate out the qnn version and the url to a seperate file, for better versin management in the future Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745/) Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745) [ghstack-poisoned]

Pull Request resolved: #11832 A few changes 1. Use the release package from https://releases.llvm.org/ to install libcpp, so we can install from different linux in addition to Ubuntu 2. Seperate out the qnn version and the url to a seperate file, for better versin management in the future ghstack-source-id: 291965571 Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745/)

facebook-github-bot · 2025-06-22T21:58:36Z

This pull request was exported from Phabricator. Differential Revision: D77048745

cccclai · 2025-06-23T17:56:23Z

@haowhsu-quic what do you think about this change? I was thinking provide an easier way (like run backends/qualcomm/scripts/install_qnn_sdk.sh) to help users to set up QNN SDK, such that it's easy for users to finish the pre-requisite, and hopefully it's also easier to bump the qnn version in the future if they're in one file

A few changes 1. Use the release package from https://releases.llvm.org/ to install libcpp, so we can install from different linux in addition to Ubuntu 2. Seperate out the qnn version and the url to a seperate file, for better versin management in the future Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745/) Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745) [ghstack-poisoned]

Pull Request resolved: #11832 A few changes 1. Use the release package from https://releases.llvm.org/ to install libcpp, so we can install from different linux in addition to Ubuntu 2. Seperate out the qnn version and the url to a seperate file, for better versin management in the future ghstack-source-id: 294656897 Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745/)

facebook-github-bot · 2025-07-07T18:13:18Z

This pull request was exported from Phabricator. Differential Revision: D77048745

A few changes 1. Use the release package from https://releases.llvm.org/ to install libcpp, so we can install from different linux in addition to Ubuntu 2. Seperate out the qnn version and the url to a seperate file, for better versin management in the future Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745/) Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745) [ghstack-poisoned]

Pull Request resolved: #11832 A few changes 1. Use the release package from https://releases.llvm.org/ to install libcpp, so we can install from different linux in addition to Ubuntu 2. Seperate out the qnn version and the url to a seperate file, for better versin management in the future ghstack-source-id: 294996148 Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745/)

facebook-github-bot · 2025-07-08T23:30:21Z

This pull request was exported from Phabricator. Differential Revision: D77048745

cccclai · 2025-07-10T16:54:27Z

@shewu-quic does it look good now?

shewu-quic

Thanks your effort.
LGTM.

shewu-quic · 2025-07-11T01:17:44Z

@@ -0,0 +1,145 @@
+#!/bin/bash


Would you like to change the script permission such as 755?

Can you share what I need to change? This line means it's bash script, should I do something different?

Woops, Sorry for the confusion—I meant this script, not this line.

I see, does it mean I need to add instructions in readme to change the permission for this script? Just trying to understand your intention better

Yes, I think it would be better for general user :)

Or I think you can change this file permission and push again.
https://stackoverflow.com/questions/10516201/updating-and-committing-only-a-files-permissions-using-git-version-control
https://stackoverflow.com/questions/59160266/git-and-permissions/59163100#59163100

Actually maybe let me try not requiring the permission

Updated the PR without requiring permission

A few changes 1. Use the release package from https://releases.llvm.org/ to install libcpp, so we can install from different linux in addition to Ubuntu 2. Seperate out the qnn version and the url to a seperate file, for better versin management in the future Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745/) Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745) [ghstack-poisoned]

Pull Request resolved: #11832 A few changes 1. Use the release package from https://releases.llvm.org/ to install libcpp, so we can install from different linux in addition to Ubuntu 2. Seperate out the qnn version and the url to a seperate file, for better versin management in the future ghstack-source-id: 295571010 Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745/)

cccclai · 2025-07-11T05:11:55Z

@shewu-quic thanks for reviewing! Addressed the comments.

A few changes 1. Use the release package from https://releases.llvm.org/ to install libcpp, so we can install from different linux in addition to Ubuntu 2. Seperate out the qnn version and the url to a seperate file, for better versin management in the future Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745/) Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745) [ghstack-poisoned]

Pull Request resolved: #11832 A few changes 1. Use the release package from https://releases.llvm.org/ to install libcpp, so we can install from different linux in addition to Ubuntu 2. Seperate out the qnn version and the url to a seperate file, for better versin management in the future ghstack-source-id: 295685450 Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745/)

facebook-github-bot · 2025-07-22T21:24:47Z

This pull request was exported from Phabricator. Differential Revision: D77048745

shewu-quic

Thanks. LGTM.

@cccclai

This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11832 by @cccclai ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/cccclai/30/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/cccclai/30/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/cccclai/30/orig @diff-train-skip-merge Co-authored-by: Chen Lai <chenlai@fb.com>

@cccclai

This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#11832 by @cccclai ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/cccclai/30/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/cccclai/30/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/cccclai/30/orig @diff-train-skip-merge Co-authored-by: Chen Lai <chenlai@fb.com>

Pull Request resolved: #11832 A few changes 1. Use the release package from https://releases.llvm.org/ to install libcpp, so we can install from different linux in addition to Ubuntu 2. Seperate out the qnn version and the url to a seperate file, for better versin management in the future ghstack-source-id: 295685450 Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745/)

Install libcpp from release package other than apt-get

40f581b

Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745/) [ghstack-poisoned]

cccclai added a commit that referenced this pull request Jun 20, 2025

Install libcpp from release package other than apt-get

9cadaca

Differential Revision: [D77048745](https://our.internmc.facebook.com/intern/diff/D77048745/) ghstack-source-id: 291737317 Pull Request resolved: #11832

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 20, 2025

facebook-github-bot added the fb-exported label Jun 22, 2025

cccclai requested review from DannyYuyang-quic, chunit-quic, haowhsu-quic, shewu-quic and winskuo-quic June 22, 2025 21:21

cccclai marked this pull request as draft June 22, 2025 21:27

cccclai marked this pull request as ready for review June 22, 2025 22:15

shewu-quic reviewed Jul 8, 2025

View reviewed changes

Comment thread backends/qualcomm/scripts/install_qnn_sdk.sh

shewu-quic approved these changes Jul 11, 2025

View reviewed changes

shewu-quic approved these changes Jul 23, 2025

View reviewed changes

mcr229 approved these changes Jul 23, 2025

View reviewed changes

facebook-github-bot merged commit a5ba119 into gh/cccclai/30/base Jul 23, 2025
193 of 195 checks passed

facebook-github-bot deleted the gh/cccclai/30/head branch July 23, 2025 20:41

facebook-github-bot temporarily deployed to cherry-pick-bot July 23, 2025 20:41 — with GitHub Actions Inactive

pytorchbot mentioned this pull request Jul 23, 2025

Install libcpp from release package other than apt-get #12768

Merged

Conversation

cccclai commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11832

❗ 1 Active SEVs

❌ 1 New Failure

Uh oh!

facebook-github-bot commented Jun 20, 2025

Uh oh!

github-actions Bot commented Jun 20, 2025

This PR needs a release notes: label

Uh oh!

facebook-github-bot commented Jun 22, 2025

Uh oh!

facebook-github-bot commented Jun 22, 2025

Uh oh!

facebook-github-bot commented Jun 22, 2025

Uh oh!

cccclai commented Jun 23, 2025

Uh oh!

facebook-github-bot commented Jul 7, 2025

Uh oh!

Uh oh!

facebook-github-bot commented Jul 8, 2025

Uh oh!

cccclai commented Jul 10, 2025

Uh oh!

shewu-quic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cccclai commented Jul 11, 2025

Uh oh!

facebook-github-bot commented Jul 22, 2025

Uh oh!

shewu-quic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cccclai commented Jun 20, 2025 •

edited

Loading

pytorch-bot Bot commented Jun 20, 2025 •

edited

Loading

This PR needs a `release notes:` label