[ET-VK][ez] Handle zero-element tensors when building Vulkan graph#11984
Merged
Conversation
## Changes As title. ## Motivation Some models may have parameter tensors which are zero-shape (i.e. no elements). In this case, trying to serialize the tensor data will result in a null pointer exception. Differential Revision: [D77281492](https://our.internmc.facebook.com/intern/diff/D77281492/) [ghstack-poisoned]
pytorch-bot
Bot
added
the
module: vulkan
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11984
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bc7ce16 with merge base ecb85ce ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
SS-JIA
added a commit
that referenced
this pull request
Jun 25, 2025
## Changes As title. ## Motivation Some models may have parameter tensors which are zero-shape (i.e. no elements). In this case, trying to serialize the tensor data will result in a null pointer exception. Differential Revision: [D77281492](https://our.internmc.facebook.com/intern/diff/D77281492/) ghstack-source-id: 292684344 Pull Request resolved: #11984
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77281492 |
This PR needs a
|
…an graph" ## Changes As title. ## Motivation Some models may have parameter tensors which are zero-shape (i.e. no elements). In this case, trying to serialize the tensor data will result in a null pointer exception. Differential Revision: [D77281492](https://our.internmc.facebook.com/intern/diff/D77281492/) cc manuelcandales cbilgin [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: #11984 ## Changes As title. ## Motivation Some models may have parameter tensors which are zero-shape (i.e. no elements). In this case, trying to serialize the tensor data will result in a null pointer exception. Differential Revision: [D77281492](https://our.internmc.facebook.com/intern/diff/D77281492/) ghstack-source-id: 292698961
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77281492 |
…an graph" ## Changes As title. ## Motivation Some models may have parameter tensors which are zero-shape (i.e. no elements). In this case, trying to serialize the tensor data will result in a null pointer exception. Differential Revision: [D77281492](https://our.internmc.facebook.com/intern/diff/D77281492/) cc manuelcandales cbilgin [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: #11984 ## Changes As title. ## Motivation Some models may have parameter tensors which are zero-shape (i.e. no elements). In this case, trying to serialize the tensor data will result in a null pointer exception. ghstack-source-id: 292715260 Differential Revision: [D77281492](https://our.internmc.facebook.com/intern/diff/D77281492/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77281492 |
nathanaelsee
approved these changes
Jun 26, 2025
…an graph" ## Changes As title. ## Motivation Some models may have parameter tensors which are zero-shape (i.e. no elements). In this case, trying to serialize the tensor data will result in a null pointer exception. Differential Revision: [D77281492](https://our.internmc.facebook.com/intern/diff/D77281492/) cc manuelcandales cbilgin [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Jun 26, 2025
Pull Request resolved: #11984 ## Changes As title. ## Motivation Some models may have parameter tensors which are zero-shape (i.e. no elements). In this case, trying to serialize the tensor data will result in a null pointer exception. ghstack-source-id: 292864904 Differential Revision: [D77281492](https://our.internmc.facebook.com/intern/diff/D77281492/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77281492 |
facebook-github-bot
merged commit fa3d871
into
gh/SS-JIA/250/base
97 of 98 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
GregoryComer
pushed a commit
that referenced
this pull request
Jun 27, 2025
…12021) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11984 by @SS-JIA ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/250/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/250/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/249/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/250/orig @diff-train-skip-merge cc @SS-JIA @manuelcandales @cbilgin --------- Co-authored-by: Stephen Jia <ssjia@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Changes
As title.
Motivation
Some models may have parameter tensors which are zero-shape (i.e. no elements). In this case, trying to serialize the tensor data will result in a null pointer exception.
Differential Revision: D77281492
cc @manuelcandales @cbilgin