[BE] Clean pte_data_map#12255
Merged
Merged
Conversation
- Add maybe_unused to size test - Clean up and try to reduce some binary size from pte_data_map. Differential Revision: [D77904843](https://our.internmc.facebook.com/intern/diff/D77904843/) [ghstack-poisoned]
lucylq
requested review from
JacobSzwejbka,
kirklandsign,
larryliu0820 and
swolchok
as code owners
lucylq
added a commit
that referenced
this pull request
Jul 8, 2025
- Add maybe_unused to size test - Clean up and try to reduce some binary size from pte_data_map. Differential Revision: [D77904843](https://our.internmc.facebook.com/intern/diff/D77904843/) ghstack-source-id: 294753493 Pull Request resolved: #12255
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12255
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled Jobs, 1 Unrelated FailureAs of commit b0597f6 with merge base 55b3540 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77904843 |
- Add maybe_unused to size test - Clean up and try to reduce some binary size from pte_data_map. Differential Revision: [D77904843](https://our.internmc.facebook.com/intern/diff/D77904843/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Jul 8, 2025
Pull Request resolved: #12255 - Add maybe_unused to size test - Clean up and try to reduce some binary size from pte_data_map. ghstack-source-id: 294755483 @exported-using-ghexport Differential Revision: [D77904843](https://our.internmc.facebook.com/intern/diff/D77904843/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77904843 |
- Add maybe_unused to size test - Clean up and try to reduce some binary size from pte_data_map. Differential Revision: [D77904843](https://our.internmc.facebook.com/intern/diff/D77904843/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Jul 8, 2025
Pull Request resolved: #12255 - Add maybe_unused to size test. - Clean up pte_data_map. This mostly involves removing namespace executorch::ET_RUNTIME_NAMESPACE/executorch::runtime as we're already in it. - Try to reduce some binary size from pte_data_map. Using key.size() and memcmp instead of strncmp saves 16 bytes. ghstack-source-id: 294944144 @exported-using-ghexport Differential Revision: [D77904843](https://our.internmc.facebook.com/intern/diff/D77904843/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77904843 |
Gasoonjia
approved these changes
Jul 9, 2025
- Add maybe_unused to size test - Clean up and try to reduce some binary size from pte_data_map. Differential Revision: [D77904843](https://our.internmc.facebook.com/intern/diff/D77904843/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Jul 9, 2025
Pull Request resolved: #12255 - Add maybe_unused to size test. - Clean up pte_data_map. This mostly involves removing namespace executorch::ET_RUNTIME_NAMESPACE/executorch::runtime as we're already in it. - Try to reduce some binary size from pte_data_map. Using key.size() and memcmp instead of strncmp saves 16 bytes. ghstack-source-id: 295211970 @exported-using-ghexport Differential Revision: [D77904843](https://our.internmc.facebook.com/intern/diff/D77904843/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77904843 |
facebook-github-bot
merged commit 74672de
into
gh/lucylq/89/base
94 of 99 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
lucylq
added a commit
that referenced
this pull request
Jul 10, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #12255 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/89/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/89/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/89/orig @diff-train-skip-merge Co-authored-by: lucylq <lfq@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D77904843