[et] generate debug handle before opeartor decomposition#12275
Merged
Conversation
…ed graph instead of edge program Pull Request resolved: #11997 This diff update the debug handle generation, from each node in the edge program having a individual debug handle, to all nodes having a same ancestor in export graph sharing a same debug handle, which update the start point of tracing our node transformation from edge graph to exported graph generated from nn.Module, by using `from_node` as source. N6213836 is an example of how `from_node` infra works. After this diff every node sharing the same ancestor node in export graph will have same debug handle. Before this diff: {F1979833525} After this diff: {F1979833595} and if quantized: {F1979833708} Beyond that, placeholder and output node will no longer have debug handle. ghstack-source-id: 294784602 @exported-using-ghexport Differential Revision: [D76860368](https://our.internmc.facebook.com/intern/diff/D76860368/)
pytorchbot
requested review from
Gasoonjia,
JacobSzwejbka and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12275
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 2 PendingAs of commit ef680a1 with merge base b342f83 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This PR needs a
|
psiddh
approved these changes
Jul 8, 2025
Tanish2101
pushed a commit
to Tanish2101/executorch
that referenced
this pull request
Jul 9, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#11997 by @Gasoonjia ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/17/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/17/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/17/orig @diff-train-skip-merge Co-authored-by: gasoonjia <gasoonjia@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #11997 by @Gasoonjia
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/17/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/17/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/17/orig
@diff-train-skip-merge