[ET-VK][testing] Q/DQ/CQP op comprehensive delegate dynamic quantization testing#12439
Merged
Conversation
…ion testing Pull Request resolved: #12210 # Context We need to ensure that most of the operators that were created work in tandem with each other for dynamic quantization. # Changes This creates two test cases to test the per_token and per_tensor pipeline to ensure that the whole full quantization workflow works as intended. ghstack-source-id: 295972784 @exported-using-ghexport Differential Revision: [D77746139](https://our.internmc.facebook.com/intern/diff/D77746139/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12439
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
# Context We need a tensor variant for dequantize/quantize operators since that is the expected output of choose_qparams. # Changes This extends the logic that currently exists to support a tensor variant for scales and zeros. Differential Revision: [D77746135](https://our.internmc.facebook.com/intern/diff/D77746135/)
An error occurred while trying to automatically change base from
gh/ahmtox/37/orig
to
main
July 14, 2025 16:00
SS-JIA
requested review from
digantdesai,
kirklandsign,
larryliu0820 and
mergennachin
as code owners
digantdesai
reviewed
Jul 21, 2025
Comment on lines
+1978
to
+1979
| quant_min=-2147483648, # int32 min | ||
| quant_max=2147483647, # int32 max |
Contributor
There was a problem hiding this comment.
curious why int32 and not int8?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #12210 by @ahmtox
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/ahmtox/38/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/ahmtox/38/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/ahmtox/37/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/ahmtox/38/orig
@diff-train-skip-merge