Android use new glslc#14596
Merged
Merged
Conversation
Summary: Title says it all. The `glslc` binary distributed with the Android NDK can no longer be used to build the Vulkan delegate since it doesn't support the GL_EXT_integer_dot_product extension. This PR updates the CMakeLists.txt to look for the `glslc` installed on the system instead by default.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14596
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 7 Pending, 2 Unrelated FailuresAs of commit deb59e4 with merge base dc87d22 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
SS-JIA
approved these changes
Sep 25, 2025
Contributor
Author
|
@pytorchbot cherry-pick --onto release/1.0 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
Sep 25, 2025
Validated by workflow https://github.com/pytorch/executorch/actions/runs/18013292360 Currently download SDK each time when we build vulkan AAR. Co-authored-by: Stephen Jia <ssjia@meta.com> (cherry picked from commit ebabf52)
Collaborator
Cherry picking #14596The cherry pick PR is at #14600 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
kirklandsign
added a commit
that referenced
this pull request
Sep 25, 2025
Validated by workflow https://github.com/pytorch/executorch/actions/runs/18013292360 Currently download SDK each time when we build vulkan AAR. Co-authored-by: Stephen Jia <ssjia@meta.com>
jirioc
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Dec 19, 2025
Validated by workflow https://github.com/pytorch/executorch/actions/runs/18013292360 Currently download SDK each time when we build vulkan AAR. Co-authored-by: Stephen Jia <ssjia@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run workflow