NXP backend: Add support for softmax with the new Neutron flow.#19739
Open
irtrukhina wants to merge 6 commits into
Open
NXP backend: Add support for softmax with the new Neutron flow.#19739irtrukhina wants to merge 6 commits into
softmax with the new Neutron flow.#19739irtrukhina wants to merge 6 commits into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19739
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit f504223 with merge base 2759ef1 ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
|
robert-kalmar
added
module: nxp
irtrukhina
force-pushed
the
feature/EIEX-728_revisit_softmax_support
branch
from
154ffff to
56a1296
Compare
irtrukhina
force-pushed
the
feature/EIEX-728_revisit_softmax_support
branch
from
c8324ed to
c122421
Compare
| 1. Input and Output must be INT8/UINT8 | ||
| 2. Channels <= 2040 | ||
| 3. Total spatial size (H*W) <= 4096 | ||
| 3. Total spatial size <= 4096 |
Collaborator
There was a problem hiding this comment.
Nit: As far as I know total spatial size is not a universally known term. Before your change, it was supposed to represent H*W, whereas now it means N*H*W. Please keep the explicit definition here.
Collaborator
|
Please take a look at the canceled pull / unittest-nxp-neutron / linux-job (pull_request). Otherwise, LGTM |
irtrukhina
force-pushed
the
feature/EIEX-728_revisit_softmax_support
branch
from
502f045 to
f504223
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for the
softmaxto the Neutron backend using the new Neutron MLIR flow. Add new tests and update old tests for thesoftmaxas well.Test plan
New tests are included in the PR.
cc @robert-kalmar @JakeStevens @digantdesai @rascani