Skip to content

Upload named-data constants in WebGPUGraph#19955

Closed
JulianCloudNTH wants to merge 1 commit into
gh/JulianCloudNTH/1/basefrom
gh/JulianCloudNTH/1/head
Closed

Upload named-data constants in WebGPUGraph#19955
JulianCloudNTH wants to merge 1 commit into
gh/JulianCloudNTH/1/basefrom
gh/JulianCloudNTH/1/head

Conversation

@JulianCloudNTH

@JulianCloudNTH JulianCloudNTH commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

The Vulkan serializer that the WebGPU backend reuses stores every non-empty constant in the PTE's named-data map with offset == UINT64_MAX and a named_key, rather than inline in the VK00 blob. WebGPUGraph::build previously handled only inline constants, so a delegated op's constant weights were never uploaded and the op produced all zeros. build now also fetches named-data constants via NamedDataMap::get_data, mirroring the path VulkanBackend already uses. aten.add was unaffected since it has no constant tensors; the first consumer is the rms_norm op in the child diff.

Differential Revision: D107288998

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19955

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 2, 2026
@linux-foundation-easycla

Copy link
Copy Markdown

CLA Missing ID

  • ❌ The email address for the commit (55d78fa) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please visit our EasyCLA portal and chat with our support bot.

This was referenced Jun 2, 2026
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@JulianCloudNTH JulianCloudNTH changed the title [ExecuTorch][WebGPU] Upload named-data constants in WebGPUGraph Upload named-data constants in WebGPUGraph Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant