Skip to content

[ExecuTorch][WebGPU] Add rms_norm op#19959

Closed
JulianCloudNTH wants to merge 1 commit into
gh/JulianCloudNTH/5/basefrom
gh/JulianCloudNTH/5/head
Closed

[ExecuTorch][WebGPU] Add rms_norm op#19959
JulianCloudNTH wants to merge 1 commit into
gh/JulianCloudNTH/5/basefrom
gh/JulianCloudNTH/5/head

Conversation

@JulianCloudNTH

@JulianCloudNTH JulianCloudNTH commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Adds the et_vk.rms_norm.default operator to the WebGPU backend: a WGSL compute shader using a cooperative tree reduction, one workgroup per row. The shader mirrors the Vulkan implementation (backends/vulkan/runtime/graph/ops/impl/RmsNorm.cpp, backends/vulkan/runtime/graph/ops/glsl/rms_norm_buffer.glsl); indexing assumes contiguous fp32 inputs. The handler fails loud (throws, mirroring Vulkan's VK_CHECK_COND) on invalid shape/dtype/dispatch-limit conditions, and defaults eps to the float32 machine epsilon.

The weight constant is uploaded via the named-data path added in the parent diff.

Differential Revision: D106887028

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19959

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 51 Pending

As of commit 0fa75ba with merge base 915a82d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla

Copy link
Copy Markdown

CLA Missing ID

  • ❌ The email address for the commit (0fa75ba) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please visit our EasyCLA portal and chat with our support bot.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 2, 2026
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant