Arm backend: update Vulkan SDK setup for newer glslc #20023
Conversation
Signed-off-by: Rob Elliott <Robert.Elliott@arm.com> Change-Id: I674f2dcaf188c4d2a09d369f17907907a84e87a5
Signed-off-by: Rob Elliott <Robert.Elliott@arm.com> Change-Id: I04e5c7646c54abd054b6b9aab132cd3ec1444413
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20023
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit da2d361 with merge base 721e641 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Pull request overview
Updates the Arm VGF/Vulkan tooling and tests to rely on a newer Vulkan SDK glslc (to avoid slow shader compilation with older host glslc), and scopes custom-shader-related pytest coverage to VGF-only runs.
Changes:
- Bump referenced Vulkan SDK version to
1.4.341.1in setup docs and Vulkan CMake error messaging. - Update Arm Vulkan SDK setup script to download/use SDK
glslcand prepend the SDKbindirectory onPATH. - Rename custom-shader-related ARM tests to include
_vgf_so they run under the VKML/VGF test selection and are excluded from baremetal flows.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/source/backends/arm-vgf/tutorials/vgf-getting-started.md | Updates the Vulkan SDK version shown in the glslc PATH troubleshooting guidance. |
| backends/arm/scripts/docgen/vgf/vgf-getting-started-tutorial.md.in | Keeps the generated tutorial source in sync with the updated Vulkan SDK version. |
| backends/vulkan/cmake/ShaderLibrary.cmake | Updates the minimum Vulkan SDK version mentioned in the glslc missing error message. |
| backends/arm/scripts/vulkan_utils.sh | Moves to Vulkan SDK 1.4.341.1 (URLs + SHA256) and prepends SDK bin to PATH to prefer SDK glslc. |
| backends/arm/test/passes/test_rewrite_grid_sampler_to_tosa_custom_pass.py | Renames the test to include _vgf_ for VGF-only selection. |
| backends/arm/test/ops/test_custom_shader_lowering.py | Renames shader-lowering tests to include _vgf_ for VGF-only selection. |
| backends/arm/test/misc/test_custom_shader_payloads.py | Renames payload tests to include _vgf_ for VGF-only selection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| FATAL_ERROR | ||
| "glslc from the Vulkan SDK must be installed to build the Vulkan backend. " | ||
| "Please install the Vulkan SDK 1.4.321.0 or newer from " | ||
| "Please install the Vulkan SDK 1.4.341.1 or newer from " |
There was a problem hiding this comment.
it seemed good to align versions for this - but if it's a problem we can drop this guidance back and just VGF requires newer. But 321 was getting a bit old so good to move.
|
Since this is all Arm backend other than a 1 line doc change i'll go ahead as-is. and @SS-JIA we can revert the documentation suggested revision bump for glslc in vulkan backend. |
update Vulkan SDK setup for newer glslc, which fixes testing time shader compiles where the system had an old glslc (and revises the version used in our test scripts) Also mark custom shader tests as vgf so they run in just the VGF or general testing, not in e.g. baremetal. cc @SS-JIA @manuelcandales @digantdesai @cbilgin @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @rascani --------- Signed-off-by: Rob Elliott <Robert.Elliott@arm.com>
update Vulkan SDK setup for newer glslc, which fixes testing time shader compiles where the system had an old glslc (and revises the version used in our test scripts)
Also mark custom shader tests as vgf so they run in just the VGF or general testing, not in e.g. baremetal.
cc @SS-JIA @manuelcandales @digantdesai @cbilgin @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @rascani