Skip to content

NXP backend: Improve test result gathering#20024

Merged
roman-janik-nxp merged 2 commits into
pytorch:mainfrom
nxp-upstream:feature/nxg11066/EIEX-925-Improve-test-result-gathering
Jun 18, 2026
Merged

NXP backend: Improve test result gathering#20024
roman-janik-nxp merged 2 commits into
pytorch:mainfrom
nxp-upstream:feature/nxg11066/EIEX-925-Improve-test-result-gathering

Conversation

@roman-janik-nxp

@roman-janik-nxp roman-janik-nxp commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

Feature for creating improved test results for reporting when test log-level is set to DEBUG. Adds IR models to .outputs/test_dir, result tensor differences, text variant of input and result tensors, summary with test info.

Test plan

Test provided. All tests that use NSYS.

cc @robert-kalmar

@roman-janik-nxp roman-janik-nxp added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Jun 4, 2026
@pytorch-bot

pytorch-bot Bot commented Jun 4, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20024

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 9 Cancelled Jobs, 5 Pending, 6 Unrelated Failures, 2 Unclassified Failures

As of commit 8bdbaf7 with merge base 0da9ca3 (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 4, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 4, 2026

Copy link
Copy Markdown

CLA Not Signed

@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Jun 4, 2026
@roman-janik-nxp

Copy link
Copy Markdown
Collaborator Author

@novak-vaclav

Comment thread backends/nxp/tests/model_output_comparator.py
Comment thread backends/nxp/tests/nsys_testing.py Outdated
Comment thread backends/nxp/tests/nsys_testing.py Outdated
Comment thread backends/nxp/tests/model_output_comparator.py Outdated
Comment thread backends/nxp/tests/generic_tests/test_debug_results.py
Comment thread backends/nxp/tests/generic_tests/test_debug_results.py
Comment thread backends/nxp/tests/utils.py Outdated
Comment thread backends/nxp/tests/nsys_testing.py Outdated
Comment thread backends/nxp/tests/nsys_testing.py
Comment thread backends/nxp/tests/nsys_testing.py Outdated
Comment thread backends/nxp/tests/nsys_testing.py
Comment thread backends/nxp/tests/generic_tests/test_quantized_input_data.py
Comment thread backends/nxp/tests/generic_tests/test_debug_results.py
Comment thread backends/nxp/tests/model_output_comparator.py
Comment thread backends/nxp/tests/model_output_comparator.py Outdated
Comment thread backends/nxp/tests/nsys_testing.py Outdated
Comment thread backends/nxp/tests/nsys_testing.py Outdated
Comment thread backends/nxp/tests/nsys_testing.py
@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-925-Improve-test-result-gathering branch from ceed080 to 9b79072 Compare June 9, 2026 11:30
@novak-vaclav

Copy link
Copy Markdown
Contributor

Provided additional information to some of my comments. Otherwise LGTM

@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-925-Improve-test-result-gathering branch 3 times, most recently from c4223bb to 1f7d775 Compare June 11, 2026 11:17
@roman-janik-nxp roman-janik-nxp marked this pull request as ready for review June 11, 2026 14:38
Comment thread backends/nxp/tests/generic_tests/test_debug_results.py
Comment thread backends/nxp/neutron_partitioner.py
Comment thread backends/nxp/nxp_backend.py Outdated
Comment thread backends/nxp/nxp_backend.py Outdated
@roman-janik-nxp

Copy link
Copy Markdown
Collaborator Author

Internal CI: https://bamboo3.sw.nxp.com/browse/MLTECE-EXIGH183-13.
CI is passing please review again.

@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-925-Improve-test-result-gathering branch from 0b19317 to a14d65f Compare June 17, 2026 15:26
@roman-janik-nxp

Copy link
Copy Markdown
Collaborator Author

Resolved the test_dir -> intermediates_dir and export condition in nxp_backend. Added parallel run for pytest NXP backend test.

@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-925-Improve-test-result-gathering branch from a14d65f to 8bdbaf7 Compare June 18, 2026 13:48
@roman-janik-nxp

Copy link
Copy Markdown
Collaborator Author

The failing checks seem unrelated and the internal build is passing. Merging.

@roman-janik-nxp roman-janik-nxp merged commit 30108d7 into pytorch:main Jun 18, 2026
447 of 492 checks passed
@roman-janik-nxp roman-janik-nxp deleted the feature/nxg11066/EIEX-925-Improve-test-result-gathering branch June 18, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants