Skip to content

NXP backend: Resolve mean.dim format related issue.#20218

Merged
MartinPavella merged 2 commits into
pytorch:mainfrom
nxp-upstream:nxg01483/EIEX-937-fix-mean.dim-keep_dim-false-bug
Jun 18, 2026
Merged

NXP backend: Resolve mean.dim format related issue.#20218
MartinPavella merged 2 commits into
pytorch:mainfrom
nxp-upstream:nxg01483/EIEX-937-fix-mean.dim-keep_dim-false-bug

Conversation

@MartinPavella

@MartinPavella MartinPavella commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

The existing mean.dim support in NXP backend failed to consider the format related implications of the operators
dimension reducing ability". This PR correctly identifies these edge cases and handles conversion to Neutron IR accordingly.

Test plan

Unit tests provided.

cc @robert-kalmar @JakeStevens @digantdesai @rascani

@MartinPavella MartinPavella self-assigned this Jun 11, 2026
@MartinPavella MartinPavella added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Jun 11, 2026
@pytorch-bot

pytorch-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20218

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 2 Unrelated Failures

As of commit e5ac69e with merge base c37b6c3 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 11, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 11, 2026

Copy link
Copy Markdown

CLA Not Signed

@MartinPavella

Copy link
Copy Markdown
Collaborator Author

@novak-vaclav please feel free to have a look.

@MartinPavella MartinPavella force-pushed the nxg01483/EIEX-937-fix-mean.dim-keep_dim-false-bug branch from 76d19fb to 3b414d5 Compare June 17, 2026 06:34
@MartinPavella MartinPavella force-pushed the nxg01483/EIEX-937-fix-mean.dim-keep_dim-false-bug branch from 3b414d5 to 5505e5a Compare June 17, 2026 09:36
This is a temporary fix to enable our workflow. A propper fix (test parallelism) is currently being worked on.
@MartinPavella MartinPavella force-pushed the nxg01483/EIEX-937-fix-mean.dim-keep_dim-false-bug branch from 5505e5a to e5ac69e Compare June 17, 2026 11:35
@MartinPavella

Copy link
Copy Markdown
Collaborator Author

The failing checks seem unrelated and the internal CI is passing. MErging.

@MartinPavella MartinPavella merged commit 0dbaed4 into pytorch:main Jun 18, 2026
176 of 182 checks passed
@MartinPavella MartinPavella deleted the nxg01483/EIEX-937-fix-mean.dim-keep_dim-false-bug branch June 18, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants