NXP backend: Resolve mean.dim format related issue.#20218
Merged
MartinPavella merged 2 commits intoJun 18, 2026
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20218
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 2 Unrelated FailuresAs of commit e5ac69e with merge base c37b6c3 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Collaborator
Author
|
@novak-vaclav please feel free to have a look. |
robert-kalmar
approved these changes
Jun 16, 2026
76d19fb to
3b414d5
Compare
3b414d5 to
5505e5a
Compare
This is a temporary fix to enable our workflow. A propper fix (test parallelism) is currently being worked on.
5505e5a to
e5ac69e
Compare
Collaborator
Author
|
The failing checks seem unrelated and the internal CI is passing. MErging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The existing
mean.dimsupport in NXP backend failed to consider the format related implications of the operatorsdimension reducing ability". This PR correctly identifies these edge cases and handles conversion to Neutron IR accordingly.
Test plan
Unit tests provided.
cc @robert-kalmar @JakeStevens @digantdesai @rascani