NXP backend: Enable MM and AddMM with new Neutron flow.#20278
Open
MartinPavella wants to merge 4 commits into
Open
NXP backend: Enable MM and AddMM with new Neutron flow.#20278MartinPavella wants to merge 4 commits into
MM and AddMM with new Neutron flow.#20278MartinPavella wants to merge 4 commits into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20278
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 3 Unrelated FailuresAs of commit 896a8c2 with merge base 55c54c7 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Collaborator
Author
|
@novak-vaclav, @irtrukhina please feel free to have a look as well. |
9c886de to
3495635
Compare
3495635 to
605f986
Compare
605f986 to
3044d1d
Compare
3044d1d to
896a8c2
Compare
| for which this predicate returns True. By default, Q/Dq nodes are ignored. | ||
| """ | ||
| if filter_fn is None: | ||
| filter_fn = is_not_qdq_node |
Collaborator
There was a problem hiding this comment.
But if you add filter, the default "QDQ nodes ignore does not applies anymore, right? What might be misleading.
Did you consider having the the is_not_qdq_node as default argument for filter_fn? Does the linter complains in this case?
roman-janik-nxp
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, need to wait on internal tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables the
MMandAddMMoperators in the NXP backend using the new Neutron C MLIR flow.Test plan
Unit tests provided.
cc @robert-kalmar @JakeStevens @digantdesai @rascani