Skip to content

NXP backend: Enable MM and AddMM with new Neutron flow.#20278

Open
MartinPavella wants to merge 4 commits into
pytorch:mainfrom
nxp-upstream:nxg01483/EIEX-862-add-mm-addmm-support-using-new-neutron-flow
Open

NXP backend: Enable MM and AddMM with new Neutron flow.#20278
MartinPavella wants to merge 4 commits into
pytorch:mainfrom
nxp-upstream:nxg01483/EIEX-862-add-mm-addmm-support-using-new-neutron-flow

Conversation

@MartinPavella

@MartinPavella MartinPavella commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR enables the MM and AddMM operators in the NXP backend using the new Neutron C MLIR flow.

Test plan

Unit tests provided.

cc @robert-kalmar @JakeStevens @digantdesai @rascani

@MartinPavella MartinPavella self-assigned this Jun 15, 2026
@MartinPavella MartinPavella added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Jun 15, 2026
@pytorch-bot

pytorch-bot Bot commented Jun 15, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20278

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 3 Unrelated Failures

As of commit 896a8c2 with merge base 55c54c7 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 15, 2026

Copy link
Copy Markdown

CLA Not Signed

@MartinPavella

Copy link
Copy Markdown
Collaborator Author

@novak-vaclav, @irtrukhina please feel free to have a look as well.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 15, 2026
@MartinPavella MartinPavella force-pushed the nxg01483/EIEX-862-add-mm-addmm-support-using-new-neutron-flow branch from 9c886de to 3495635 Compare June 17, 2026 06:36
@MartinPavella MartinPavella force-pushed the nxg01483/EIEX-862-add-mm-addmm-support-using-new-neutron-flow branch from 3495635 to 605f986 Compare June 17, 2026 13:54
@MartinPavella MartinPavella force-pushed the nxg01483/EIEX-862-add-mm-addmm-support-using-new-neutron-flow branch from 605f986 to 3044d1d Compare June 18, 2026 07:02
@MartinPavella MartinPavella force-pushed the nxg01483/EIEX-862-add-mm-addmm-support-using-new-neutron-flow branch from 3044d1d to 896a8c2 Compare June 19, 2026 07:50
for which this predicate returns True. By default, Q/Dq nodes are ignored.
"""
if filter_fn is None:
filter_fn = is_not_qdq_node

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if you add filter, the default "QDQ nodes ignore does not applies anymore, right? What might be misleading.
Did you consider having the the is_not_qdq_node as default argument for filter_fn? Does the linter complains in this case?

@roman-janik-nxp roman-janik-nxp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need to wait on internal tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants