Extract _lora_call into a shared free function in lora.py (#20306)#20306
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20306
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 30 Pending, 2 Unclassified FailuresAs of commit dcfea58 with merge base ef5c8a7 ( NEW FAILURES - The following jobs have failed:
UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@derekdixu has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108757232. |
9e2fc1d to
980454a
Compare
|
This PR needs a
|
_lora_call into a shared free function in lora.py_lora_call into a shared free function in lora.py (#20306)
…h#20306) Summary: Both `MultimodalTransformer` (transformer.py) and `StaticAttention` (static_attention.py) had identical `_lora_call` methods. Extracted the logic into a module-level `lora_call()` function in `lora.py` and updated both consumers to import and call it directly. Differential Revision: D108757232
980454a to
c62c9f7
Compare
…h#20306) Summary: Both `MultimodalTransformer` (transformer.py) and `StaticAttention` (static_attention.py) had identical `_lora_call` methods. Extracted the logic into a module-level `lora_call()` function in `lora.py` and updated both consumers to import and call it directly. Reviewed By: billmguo Differential Revision: D108757232
c62c9f7 to
bee4dad
Compare
…h#20306) Summary: Both `MultimodalTransformer` (transformer.py) and `StaticAttention` (static_attention.py) had identical `_lora_call` methods. Extracted the logic into a module-level `lora_call()` function in `lora.py` and updated both consumers to import and call it directly. Reviewed By: billmguo Differential Revision: D108757232
bee4dad to
778eb03
Compare
…h#20306) Summary: Pull Request resolved: pytorch#20306 Both `MultimodalTransformer` (transformer.py) and `StaticAttention` (static_attention.py) had identical `_lora_call` methods. Extracted the logic into a module-level `lora_call()` function in `lora.py` and updated both consumers to import and call it directly. Reviewed By: billmguo Differential Revision: D108757232 Signed-off-by: Di Xu <dixu@meta.com>
778eb03 to
b17797e
Compare
…h#20306) Summary: Both `MultimodalTransformer` (transformer.py) and `StaticAttention` (static_attention.py) had identical `_lora_call` methods. Extracted the logic into a module-level `lora_call()` function in `lora.py` and updated both consumers to import and call it directly. Reviewed By: billmguo Differential Revision: D108757232
b17797e to
b418779
Compare
…h#20306) Summary: Pull Request resolved: pytorch#20306 Both `MultimodalTransformer` (transformer.py) and `StaticAttention` (static_attention.py) had identical `_lora_call` methods. Extracted the logic into a module-level `lora_call()` function in `lora.py` and updated both consumers to import and call it directly. Reviewed By: billmguo Differential Revision: D108757232 Signed-off-by: Di Xu <dixu@meta.com>
b418779 to
b6add03
Compare
…h#20306) Summary: Pull Request resolved: pytorch#20306 Both `MultimodalTransformer` (transformer.py) and `StaticAttention` (static_attention.py) had identical `_lora_call` methods. Extracted the logic into a module-level `lora_call()` function in `lora.py` and updated both consumers to import and call it directly. Reviewed By: billmguo Differential Revision: D108757232 Signed-off-by: Di Xu <dixu@meta.com>
b6add03 to
dcfea58
Compare
Summary:
Both
MultimodalTransformer(transformer.py) andStaticAttention(static_attention.py) had identical_lora_callmethods. Extracted the logic into a module-levellora_call()function inlora.pyand updated both consumers to import and call it directly.Reviewed By: billmguo
Differential Revision: D108757232
Signed-off-by: Di Xu dixu@meta.com