Skip to content

ovr_config | build_mode | Migrate constraint refs from aliases to subtargets. (#20318)#20318

Open
nlutsenko wants to merge 1 commit into
mainfrom
export-D108831239
Open

ovr_config | build_mode | Migrate constraint refs from aliases to subtargets. (#20318)#20318
nlutsenko wants to merge 1 commit into
mainfrom
export-D108831239

Conversation

@nlutsenko

@nlutsenko nlutsenko commented Jun 17, 2026

Copy link
Copy Markdown

Summary: Pull Request resolved: #20318

Reviewed By: 8Keep

Differential Revision: D108831239

Copilot AI review requested due to automatic review settings June 17, 2026 04:00
@pytorch-bot

pytorch-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20318

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 3 Unrelated Failures

As of commit f7871d1 with merge base 30108d7 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 17, 2026
@meta-codesync

meta-codesync Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@nlutsenko has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108831239.

@8Keep 8Keep left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the fbcode-only backend test target configuration to reference the ovr_config//build_mode sanitizer constraint via its new subtarget form, aligning with the “migrate constraint refs from aliases to subtargets” change.

Changes:

  • Replace ovr_config//build_mode/constraints:sanitizer with ovr_config//build_mode/constraints:build_mode[sanitizer] in the TSAN test target modifiers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@meta-codesync meta-codesync Bot changed the title ovr_config | build_mode | Migrate constraint refs from aliases to subtargets. ovr_config | build_mode | Migrate constraint refs from aliases to subtargets. (#20318) Jun 17, 2026
meta-codesync Bot pushed a commit that referenced this pull request Jun 17, 2026
…targets. (#20318)

Summary: Pull Request resolved: #20318

Reviewed By: 8Keep

Differential Revision: D108831239
@meta-codesync meta-codesync Bot force-pushed the export-D108831239 branch from 6c01bcc to 8966aa4 Compare June 17, 2026 08:42
meta-codesync Bot pushed a commit that referenced this pull request Jun 18, 2026
…targets. (#20318)

Summary: Pull Request resolved: #20318

Reviewed By: 8Keep

Differential Revision: D108831239
@meta-codesync meta-codesync Bot force-pushed the export-D108831239 branch from 8966aa4 to fb31c54 Compare June 18, 2026 06:59
Copilot AI review requested due to automatic review settings June 18, 2026 06:59
@nlutsenko nlutsenko removed the request for review from Copilot June 18, 2026 06:59
…targets. (#20318)

Summary: Pull Request resolved: #20318

Reviewed By: 8Keep

Differential Revision: D108831239
Copilot AI review requested due to automatic review settings June 18, 2026 18:10
@meta-codesync meta-codesync Bot force-pushed the export-D108831239 branch from fb31c54 to f7871d1 Compare June 18, 2026 18:10
@nlutsenko nlutsenko removed the request for review from Copilot June 18, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants