Guard nil asset.contentURL in ETCoreMLModel initWithAsset:

[KushalAdhvaryu]

Summary:
Fixes EXC_BAD_ACCESS / KERN_INVALID_ADDRESS in -[ETCoreMLModel initWithAsset:configuration:orderedInputNames:orderedOutputNames:error:] at xplat/executorch/backends/apple/coreml/runtime/delegate/ETCoreMLModel.mm:197.

Root cause: the initializer calls [asset keepAliveAndReturnError:] which validates the asset's file lock but does not validate that asset.contentURL is non-nil. When the compiled .mlmodelc was reaped from disk between the lock and the load (or the asset was never fully materialized), asset.contentURL returns nil. +[MLModel modelWithContentsOfURL:configuration:error:] does not tolerate a nil URL — it deref's into CoreML internals and faults.

Fix: capture asset.contentURL into a local, return nil with ETCoreMLErrorCorruptedModel populated in the out-error if the URL is nil. No behavior change for valid assets — callers already handle the documented nil + error contract.

Reviewed By: metascroy

Differential Revision: D108334793

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20338

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Pending, 1 Unrelated Failure

As of commit 8cce690 with merge base 0eb8247 ():

NEW FAILURES - The following jobs have failed:

• Cadence Build & Test / hifi-build / hifi4 (gh)
  Input required and not supplied: aws-region
• Cadence Build & Test / vision-build / vision (gh)
  Input required and not supplied: aws-region
• pull / test-arm-backend-no-driver (test_pytest_models_tosa) / linux-job (gh)
  RuntimeError: Command docker exec -t b1bd7e5bb3492c370c853a5ad7a4e3ccf83b00847dd518ab8ba9ec4932fb00d0 /exec failed with exit code 1
• pull / test-llama-runner-qnn-linux (fp32, qnn_16a16w, qnn) / linux-job (gh)
  RuntimeError: Command docker exec -t 784d8c2b84aa5f860f7169e8fe444bde052dbb1481db2c0350ec954b1f560c67 /exec failed with exit code 137

FLAKY - The following job failed but was likely due to flakiness present on trunk:

• pull / test-qnn-testsuite-linux / test-backend-linux (qnn, models) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[meta-codesync]

@KushalAdhvaryu has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108334793.

[linux-foundation-easycla]

• ❌ The email address for the commit (8cce690) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please visit our EasyCLA portal and chat with our support bot.

[github-actions]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

[cymbalrush]

Thank you!