Skip to content

[ET-VK][conv2d_dw] Fix test requesting nonexistent sned b1x1 shader#20343

Merged
meta-codesync[bot] merged 1 commit into
gh/SS-JIA/559/basefrom
gh/SS-JIA/559/head
Jun 18, 2026
Merged

[ET-VK][conv2d_dw] Fix test requesting nonexistent sned b1x1 shader#20343
meta-codesync[bot] merged 1 commit into
gh/SS-JIA/559/basefrom
gh/SS-JIA/559/head

Conversation

@SS-JIA

@SS-JIA SS-JIA commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

The test_conv2d_dw benchmark aborted on device (SIGABRT) with an uncaught vkcompute::vkapi::Error from ShaderRegistry::get_shader_info: "Could not find ShaderInfo with name conv2d_dw_sned_output_tile_3x3_b1x1_float". pick_conv2d_dw_shader_with_selector in TestConv2dDw.cpp appended the _b1x1 batch-tile infix for any 3x3 case whenever impl_selector == "b1x1", with no stride_equals_dilation guard. For a strided 3x3 case it had already appended _sned, producing conv2d_dw_sned_output_tile_3x3_b1x1_float — a variant the sned shader family never generates (sned shaders are not batch-tiled; only the non-sned conv2d_dw_output_tile family has _b1x1 variants).

This guards the forced _b1x1 append on stride_equals_dilation, matching the production pick_conv2d_dw_shader in Conv2dDW.cpp. A forced b1x1 selector on a strided 3x3 case now falls back to the existing un-suffixed sned shader instead of requesting an unbacked variant.

Differential Revision: D108916041

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20343

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Cancelled Job, 1 Unrelated Failure

As of commit 545a3ad with merge base 0eb8247 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 17, 2026
@linux-foundation-easycla

Copy link
Copy Markdown

CLA Missing ID

  • ❌ The email address for the commit (545a3ad) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please visit our EasyCLA portal and chat with our support bot.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync Bot merged commit 82bc92a into gh/SS-JIA/559/base Jun 18, 2026
185 of 193 checks passed
@meta-codesync meta-codesync Bot deleted the gh/SS-JIA/559/head branch June 18, 2026 01:52
@meta-codesync meta-codesync Bot temporarily deployed to cherry-pick-bot June 18, 2026 01:52 Inactive
SS-JIA pushed a commit that referenced this pull request Jun 18, 2026
The test_conv2d_dw benchmark aborted on device (SIGABRT) with an uncaught vkcompute::vkapi::Error from ShaderRegistry::get_shader_info: "Could not find ShaderInfo with name conv2d_dw_sned_output_tile_3x3_b1x1_float". pick_conv2d_dw_shader_with_selector in TestConv2dDw.cpp appended the _b1x1 batch-tile infix for any 3x3 case whenever impl_selector == "b1x1", with no stride_equals_dilation guard. For a strided 3x3 case it had already appended _sned, producing conv2d_dw_sned_output_tile_3x3_b1x1_float — a variant the sned shader family never generates (sned shaders are not batch-tiled; only the non-sned conv2d_dw_output_tile family has _b1x1 variants).

This guards the forced _b1x1 append on stride_equals_dilation, matching the production pick_conv2d_dw_shader in Conv2dDW.cpp. A forced b1x1 selector on a strided 3x3 case now falls back to the existing un-suffixed sned shader instead of requesting an unbacked variant.

Differential Revision: [D108916041](https://our.internmc.facebook.com/intern/diff/D108916041/)


ghstack-source-id: 394480011
Pull-Request: #20343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants