[ET-VK][conv2d_dw] Fix test requesting nonexistent sned b1x1 shader#20343
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20343
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Cancelled Job, 1 Unrelated FailureAs of commit 545a3ad with merge base 0eb8247 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This PR needs a
|
metascroy
approved these changes
Jun 17, 2026
82bc92a
into
gh/SS-JIA/559/base
185 of 193 checks passed
SS-JIA
pushed a commit
that referenced
this pull request
Jun 18, 2026
The test_conv2d_dw benchmark aborted on device (SIGABRT) with an uncaught vkcompute::vkapi::Error from ShaderRegistry::get_shader_info: "Could not find ShaderInfo with name conv2d_dw_sned_output_tile_3x3_b1x1_float". pick_conv2d_dw_shader_with_selector in TestConv2dDw.cpp appended the _b1x1 batch-tile infix for any 3x3 case whenever impl_selector == "b1x1", with no stride_equals_dilation guard. For a strided 3x3 case it had already appended _sned, producing conv2d_dw_sned_output_tile_3x3_b1x1_float — a variant the sned shader family never generates (sned shaders are not batch-tiled; only the non-sned conv2d_dw_output_tile family has _b1x1 variants). This guards the forced _b1x1 append on stride_equals_dilation, matching the production pick_conv2d_dw_shader in Conv2dDW.cpp. A forced b1x1 selector on a strided 3x3 case now falls back to the existing un-suffixed sned shader instead of requesting an unbacked variant. Differential Revision: [D108916041](https://our.internmc.facebook.com/intern/diff/D108916041/) ghstack-source-id: 394480011 Pull-Request: #20343
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The test_conv2d_dw benchmark aborted on device (SIGABRT) with an uncaught vkcompute::vkapi::Error from ShaderRegistry::get_shader_info: "Could not find ShaderInfo with name conv2d_dw_sned_output_tile_3x3_b1x1_float". pick_conv2d_dw_shader_with_selector in TestConv2dDw.cpp appended the _b1x1 batch-tile infix for any 3x3 case whenever impl_selector == "b1x1", with no stride_equals_dilation guard. For a strided 3x3 case it had already appended _sned, producing conv2d_dw_sned_output_tile_3x3_b1x1_float — a variant the sned shader family never generates (sned shaders are not batch-tiled; only the non-sned conv2d_dw_output_tile family has _b1x1 variants).
This guards the forced _b1x1 append on stride_equals_dilation, matching the production pick_conv2d_dw_shader in Conv2dDW.cpp. A forced b1x1 selector on a strided 3x3 case now falls back to the existing un-suffixed sned shader instead of requesting an unbacked variant.
Differential Revision: D108916041