Cortex-M backend: Minimize scope of cmsis_nn dependency.#20371
Merged
Conversation
For Ethos-U flows, you might want to run only the ReplaceQuantNodesPass pass which doesn't require the cmsis_nn dependency. Since the install is currently not trivial, we shouldn't force people to do it when not needed. Right now, all passes are imported when importing that pass, triggering importing cmsis_nn. - Move dependency check to only trigger when cmsis_nn is imported. - Do this by wrapping cmsis_nn, taking the chance to add typing. - Lazy load passes to not require importing all passes. Tested by running from executorch.backends.cortex_m.passes import ReplaceQuantNodesPass Before the patch this triggers an error if cmsis_nn is not installed. After the patch, it doesn't. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: Ic674509b09355145cdaa601008ba19074bda0283
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20371
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit bfea4e5 with merge base 3707efa ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
rascani
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Ethos-U flows, you might want to run only the ReplaceQuantNodesPass pass which doesn't require the cmsis_nn dependency. Since the install is currently not trivial, we shouldn't force people to do it when not needed.
Right now, all passes are imported when importing that pass, triggering importing cmsis_nn.
Tested by running
from executorch.backends.cortex_m.passes import ReplaceQuantNodesPass
Before the patch this triggers an error if cmsis_nn is not installed. After the patch, it doesn't.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani @psiddh @AdrianLundell