Skip to content

Arm backend: Fix test_nss.py#20373

Merged
zingo merged 1 commit into
pytorch:mainfrom
zingo:Arm-backend-Fix-test_nss.py
Jun 18, 2026
Merged

Arm backend: Fix test_nss.py#20373
zingo merged 1 commit into
pytorch:mainfrom
zingo:Arm-backend-Fix-test_nss.py

Conversation

@zingo

@zingo zingo commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Lock down used neural-graphics-model-gym.git to version v0.3.0

cc @digantdesai @freddan80 @per @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

Lock down used neural-graphics-model-gym.git to version v0.3.0

Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com>
Change-Id: I9bf76d3156f2032f37127aa336bb273cd521857a
@zingo zingo requested a review from digantdesai as a code owner June 18, 2026 08:43
Copilot AI review requested due to automatic review settings June 18, 2026 08:43
@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes labels Jun 18, 2026
@pytorch-bot

pytorch-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20373

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 326 Pending

As of commit ae353eb with merge base 574bfca (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 18, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Jun 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR stabilizes Arm backend model test setup by pinning the neural-graphics-model-gym dependency to a known-good version, reducing test flakiness due to upstream changes.

Changes:

  • Pin neural-graphics-model-gym checkout to v0.3.0 (overridable via MODEL_GYM_REF).
  • Use a shallow clone for the pinned ref to reduce fetch time.
  • Update the copyright header year range.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zingo zingo merged commit 3707efa into pytorch:main Jun 18, 2026
503 of 518 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants