Skip to content

[Executorch] Update EXECUTORCH_LIBRARY macro#5620

Closed
kimishpatel wants to merge 1 commit into
gh/kimishpatel/87/basefrom
gh/kimishpatel/87/head
Closed

[Executorch] Update EXECUTORCH_LIBRARY macro#5620
kimishpatel wants to merge 1 commit into
gh/kimishpatel/87/basefrom
gh/kimishpatel/87/head

Conversation

@kimishpatel

@kimishpatel kimishpatel commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

Change it to generate unique static variable name. Otherwise we cant register
two ops from the same file.

Also dont know what happens when two files have the same static variable.
Probably nothing unless you are trying to refer to it from some other file.

Differential Revision: [D62623240](https://our.internmc.facebook.com/intern/diff/D62623240/)

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Sep 25, 2024

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5620

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit 4787097 with merge base b2517d6 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 25, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D62623240

@kimishpatel kimishpatel closed this Oct 1, 2024
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
Change it to generate unique static variable name. Otherwise we cant register
two ops from the same file.

Also dont know what happens when two files have the same static variable.
Probably nothing unless you are trying to refer to it from some other file.

Differential Revision: [D62623240](https://our.internmc.facebook.com/intern/diff/D62623240/)

ghstack-source-id: 244549441
Pull Request resolved: pytorch/executorch#5620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants