[Executorch][llama] Refactoring sdpa#5667
Closed
kimishpatel wants to merge 7 commits into
Closed
Conversation
- Change variable name from is_sdpa_with_kv_cache to is_seq_at_dim_1 to be more meaningful - remove seq_len as it can be derived from the size of query Differential Revision: [D62623243](https://our.internmc.facebook.com/intern/diff/D62623243/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5667
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 57b7dd8 with merge base ee32848 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62623243 |
This was referenced Sep 25, 2024
- Change variable name from is_sdpa_with_kv_cache to is_seq_at_dim_1 to be more meaningful - remove seq_len as it can be derived from the size of query Differential Revision: [D62623243](https://our.internmc.facebook.com/intern/diff/D62623243/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62623243 |
- Change variable name from is_sdpa_with_kv_cache to is_seq_at_dim_1 to be more meaningful - remove seq_len as it can be derived from the size of query Differential Revision: [D62623243](https://our.internmc.facebook.com/intern/diff/D62623243/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62623243 |
- Change variable name from is_sdpa_with_kv_cache to is_seq_at_dim_1 to be more meaningful - remove seq_len as it can be derived from the size of query Differential Revision: [D62623243](https://our.internmc.facebook.com/intern/diff/D62623243/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62623243 |
digantdesai
approved these changes
Sep 30, 2024
- Change variable name from is_sdpa_with_kv_cache to is_seq_at_dim_1 to be more meaningful - remove seq_len as it can be derived from the size of query Differential Revision: [D62623243](https://our.internmc.facebook.com/intern/diff/D62623243/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62623243 |
- Change variable name from is_sdpa_with_kv_cache to is_seq_at_dim_1 to be more meaningful - remove seq_len as it can be derived from the size of query Differential Revision: [D62623243](https://our.internmc.facebook.com/intern/diff/D62623243/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62623243 |
- Change variable name from is_sdpa_with_kv_cache to is_seq_at_dim_1 to be more meaningful - remove seq_len as it can be derived from the size of query Differential Revision: [D62623243](https://our.internmc.facebook.com/intern/diff/D62623243/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62623243 |
Contributor
|
This pull request has been merged in 29364c4. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#5667 - Change variable name from is_sdpa_with_kv_cache to is_seq_at_dim_1 to be more meaningful - remove seq_len as it can be derived from the size of query ghstack-source-id: 245751540 @exported-using-ghexport Differential Revision: [D62623243](https://our.internmc.facebook.com/intern/diff/D62623243/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D62623243