Skip to content

Lower timeout for llava-runner and eval_llama-mmlu jobs again#8339

Merged
metascroy merged 1 commit into
mainfrom
gh/swolchok/241/head
Feb 10, 2025
Merged

Lower timeout for llava-runner and eval_llama-mmlu jobs again#8339
metascroy merged 1 commit into
mainfrom
gh/swolchok/241/head

Conversation

@swolchok

Copy link
Copy Markdown
Contributor

#8173 raised these timeouts. Now that #8248 has landed to fix #8180, we should be able to lower them again. (I'm sending this early so I don't forget; double-check llava-runner running time)

[ghstack-poisoned]
@swolchok

swolchok commented Feb 10, 2025

Copy link
Copy Markdown
Contributor Author

Stack from ghstack (oldest at bottom):

@pytorch-bot

pytorch-bot Bot commented Feb 10, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8339

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8a23fab with merge base 9746ce7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 10, 2025
swolchok added a commit that referenced this pull request Feb 10, 2025
#8173 raised these timeouts. Now that #8248 has landed to fix #8180, we should be able to lower them again. (I'm sending this early so I don't forget; double-check llava-runner running time)

ghstack-source-id: cb4c169
ghstack-comment-id: 2648474106
Pull Request resolved: #8339
@swolchok swolchok requested a review from metascroy February 10, 2025 16:04
@metascroy metascroy merged commit f40212c into main Feb 10, 2025
@metascroy metascroy deleted the gh/swolchok/241/head branch February 10, 2025 18:18
@huydhn

huydhn commented Feb 10, 2025

Copy link
Copy Markdown
Contributor

Let me try to get some stats on how much time had been wasted because of missing mkl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI timeout (test-llava-runner-linux) since #7922

4 participants