build: Switch to USE_ROCTRACER and USE_XPUPTI#1141
Open
seemethere wants to merge 1 commit intogh/seemethere/3/basefrom
Open
build: Switch to USE_ROCTRACER and USE_XPUPTI#1141seemethere wants to merge 1 commit intogh/seemethere/3/basefrom
seemethere wants to merge 1 commit intogh/seemethere/3/basefrom
Conversation
seemethere
added a commit
that referenced
this pull request
Sep 4, 2025
The original variables LIBKINETO_NOROCTRACER and LIBKINETO_NOXPUPTI are deprecated in favor of USE_ROCTRACER and USE_XPUPTI. The original variables introduced double negatives which made the cmake code confusing to read. Signed-off-by: Eli Uriegas <eliuriegas@meta.com> ghstack-source-id: 8a1f46c Pull-Request: #1141
This was referenced Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The original variables LIBKINETO_NOROCTRACER and LIBKINETO_NOXPUPTI are
deprecated in favor of USE_ROCTRACER and USE_XPUPTI.
The original variables introduced double negatives which made the cmake code
confusing to read.
Signed-off-by: Eli Uriegas eliuriegas@meta.com