D91430608: [Kineto] Add PROFILE_CAPTURE_OVERLOAD_NAMES to Kineto OD config#1236
Open
ryanzhang22 wants to merge 1 commit intopytorch:mainfrom
Open
D91430608: [Kineto] Add PROFILE_CAPTURE_OVERLOAD_NAMES to Kineto OD config#1236ryanzhang22 wants to merge 1 commit intopytorch:mainfrom
ryanzhang22 wants to merge 1 commit intopytorch:mainfrom
Conversation
|
@ryanzhang22 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91587687. |
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Jan 27, 2026
…onfig (pytorch#1236) Summary: This option is available in auto-trace (under ExperimentalConfig -> capture_overload_names) but not in OD. By enabling it, the profile is instructed to include ATen overload names. Differential Revision: D91587687
ryanzhang22
force-pushed
the
export-D91587687
branch
from
0c082fe to
6321a26
Compare
…o OD trace (pytorch#1236) Summary: There are two fields (capture_overload_names, record_python_gc_info) that are available in auto-trace (under ExperimentalConfig) but not in OD. Since Kineto uses Profiler to capture PyTorch events, these need to be plumbed through to the experimental config field of the Profiler. This diff adds a path to do so. I am introducing a new struct to avoid needing to continuously add experimental config fields to the ClientInterface::prepare() method. No functional changes as this diff has interface changes blocked behind IFDEF, next diff will add the changes to Profiler in PyTorch. Differential Revision: D91587687
ryanzhang22
force-pushed
the
export-D91587687
branch
from
6321a26 to
b96c858
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This option is available in auto-trace (under ExperimentalConfig -> capture_overload_names) but not in OD. By enabling it, the profile is instructed to include ATen overload names.
Differential Revision: D91587687