Closed
Conversation
|
@divyanshk has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91710208. |
Summary: Follow up to D91619041 Rearraged the ifdefs to make the file more readable - earlier we had three definitons of `devicePropertiesJson`, now one exists. I tried to all CLANGTIDY's recommendations but it made way too many changes, will defer that for future cleanup. Reviewed By: sanrise Differential Revision: D91710208
divyanshk
force-pushed
the
export-D91710208
branch
from
f518a32 to
f4eef94
Compare
|
This pull request has been merged in c09ff73. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Follow up to D91619041
Rearraged the ifdefs to make the file more readable - earlier we had three definitons of
devicePropertiesJson, now one exists.I tried to all CLANGTIDY's recommendations but it made way too many changes, will defer that for future cleanup.
Reviewed By: sanrise
Differential Revision: D91710208