Open
Conversation
scotts
added a commit
to scotts/kineto
that referenced
this pull request
Feb 6, 2026
Summary: Migrate ROCm support from `roctracer64-lazy` to `rocprofiler-sdk-lazy`. The history of previous attempts: 1. Original PR: pytorch#1050. Eventually this PR could no longer rebase to main. 2. Attempt 1 to land, copied from original PR: D82773951; pytorch#1128. Reverted because of remote execution failures. 3. Attempt 2 to land: D86455336; pytorch#1168. Reverted because of a 10% performance regression. The performance regression has been resolved. The code has changed in two major ways since the previous attempts: 1. The activity profilers were refactored in pytorch#1219. This code needed to adapt. 2. We encountered segfaults during process exit in tests that did not actually do any profiling. This is probably a bug in `rocprofiler-sdk-lazy`. To avoid it, we're using `std::atexit()` to force an early exit. Thanks to aaronwlma/aaronwlma for the suggestion! Differential Revision: D92225068
scotts
force-pushed
the
export-D92225068
branch
from
7059824 to
0e89e92
Compare
scotts
added a commit
to scotts/kineto
that referenced
this pull request
Feb 7, 2026
Summary: Migrate ROCm support from `roctracer64-lazy` to `rocprofiler-sdk-lazy`. The history of previous attempts: 1. Original PR: pytorch#1050. Eventually this PR could no longer rebase to main. 2. Attempt 1 to land, copied from original PR: D82773951; pytorch#1128. Reverted because of remote execution failures. 3. Attempt 2 to land: D86455336; pytorch#1168. Reverted because of a 10% performance regression. The performance regression has been resolved. The code has changed in two major ways since the previous attempts: 1. The activity profilers were refactored in pytorch#1219. This code needed to adapt. 2. We encountered segfaults during process exit in tests that did not actually do any profiling. This is probably a bug in `rocprofiler-sdk-lazy`. To avoid it, we're using `std::atexit()` to force an early exit. Thanks to aaronwlma/aaronwlma for the suggestion! Differential Revision: D92225068
scotts
force-pushed
the
export-D92225068
branch
from
0e89e92 to
4d08e70
Compare
Summary: Migrate ROCm support from `roctracer64-lazy` to `rocprofiler-sdk-lazy`. The history of previous attempts: 1. Original PR: pytorch#1050. Eventually this PR could no longer rebase to main. 2. Attempt 1 to land, copied from original PR: D82773951; pytorch#1128. Reverted because of remote execution failures. 3. Attempt 2 to land: D86455336; pytorch#1168. Reverted because of a 10% performance regression. The performance regression has been resolved. The code has changed in two major ways since the previous attempts: 1. The activity profilers were refactored in pytorch#1219. This code needed to adapt. 2. We encountered segfaults during process exit in tests that did not actually do any profiling. This is probably a bug in `rocprofiler-sdk-lazy`. To avoid it, we're using `std::atexit()` to force an early exit. Thanks to aaronwlma/aaronwlma for the suggestion! Differential Revision: D92225068
scotts
force-pushed
the
export-D92225068
branch
from
4d08e70 to
bb3702e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Migrate ROCm support from
roctracer64-lazytorocprofiler-sdk-lazy. The history of previous attempts:The performance regression has been resolved. The code has changed in two major ways since the previous attempts:
rocprofiler-sdk-lazy. To avoid it, we're usingstd::atexit()to force an early exit. Thanks to @aaronwlma for the suggestion!Differential Revision: D92225068